Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-22 Thread Ronak Patel
> On Dec 16, 2018, at 10:31 PM, Steven Liu wrote: > > Aleksey Skripka 于2018年12月14日周五 下午10:58写道: >> >> >> From e85edcc4d8b0312c7871f78ed0859ec7436be460 Mon Sep 17 00:00:00 2001 >> From: Aleksey Skripka >> Date: Fri, 14 Dec 2018 14:48:31 + >> Subject: [PATCH] libavformat/hlsenc: fix broken

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-16 Thread Steven Liu
Aleksey Skripka 于2018年12月14日周五 下午10:58写道: > > > From e85edcc4d8b0312c7871f78ed0859ec7436be460 Mon Sep 17 00:00:00 2001 > From: Aleksey Skripka > Date: Fri, 14 Dec 2018 14:48:31 + > Subject: [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file > > 1. fix addressing '->flags' while assi

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
From e85edcc4d8b0312c7871f78ed0859ec7436be460 Mon Sep 17 00:00:00 2001 From: Aleksey Skripka Date: Fri, 14 Dec 2018 14:48:31 + Subject: [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file 1. fix addressing '->flags' while assigning 'use_temp_file'. 2. before 223d2bde22ce33dcbcb6f17f

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
one more try, via 'git format-patch'. 0001-libavformat-hlsenc-fix-broken-hls_flags-temp_file.patch Description: Binary data > On 14 Dec 2018, at 17:21, Steven Liu wrote: > > > >> On Dec 14, 2018, at 19:23, Aleksey Skripka wrote: >> >>> >>> On 14 Dec 2018, at 13:10, Liu Steven wrote: >>

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Steven Liu
> On Dec 14, 2018, at 19:23, Aleksey Skripka wrote: > >> >> On 14 Dec 2018, at 13:10, Liu Steven wrote: >> >> >> >>> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: >>> >>> greetings! >>> >>> fixed version. >>> thanks. >> Is this patch create by git format-patch ? > no. > diff -up fileA fileB

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
> On 14 Dec 2018, at 13:10, Liu Steven wrote: > > > >> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: >> >> greetings! >> >> fixed version. >> thanks. > Is this patch create by git format-patch ? no. diff -up fileA fileB >> >> --- >> --- libavformat/hlsenc.c.orig 2018-12-14 09:25:06.54180

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Liu Steven
> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: > > greetings! > > fixed version. > thanks. Is this patch create by git format-patch ? > > --- > --- libavformat/hlsenc.c.orig 2018-12-14 09:25:06.541809226 + > +++ libavformat/hlsenc.c2018-12-14 09:19:16.129377384 + > @@ -1348,7

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
greetings! fixed version. thanks. --- --- libavformat/hlsenc.c.orig 2018-12-14 09:25:06.541809226 + +++ libavformat/hlsenc.c2018-12-14 09:19:16.129377384 + @@ -1348,7 +1348,7 @@ static int hls_window(AVFormatContext *s char temp_filename[1024]; int64_t sequence = FF

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Liu Steven
> 在 2018年12月14日,下午3:04,Aleksey Skripka 写道: > > greetings! > > after commit 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 temp_file functionality > totally broken. > > attached patch prototype will fix: > 1) while assigning 'use_temp_file' addressing to '->flags' is done > incorrectly in 4 place

[FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-13 Thread Aleksey Skripka
greetings! after commit 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 temp_file functionality totally broken. attached patch prototype will fix: 1) while assigning 'use_temp_file' addressing to '->flags' is done incorrectly in 4 places. 2) before that commit playlist was always created via .tmp for