Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

2020-10-08 Thread Andreas Rheinhardt
Christopher Degawa: >> You should also reset c->adaptionset_lang to NULL after freeing it. (I >> remember finding this issue myself, but somehow forgot to fix it. Strange.) > > Ah, I forgot that's what av_freep does in addition to freeing, do you > wish to make the change, or do you want me to? >

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

2020-10-08 Thread Christopher Degawa
> You should also reset c->adaptionset_lang to NULL after freeing it. (I > remember finding this issue myself, but somehow forgot to fix it. Strange.) Ah, I forgot that's what av_freep does in addition to freeing, do you wish to make the change, or do you want me to? > (Actually, the lifetime of

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

2020-10-08 Thread Andreas Rheinhardt
Christopher Degawa: > Use xmlFree instead of av_freep > > snip from libxml2: > > * xmlGetProp: > ... > * Returns the attribute value or NULL if not found. > * It's up to the caller to free the memory with xmlFree(). > > According to libxml2, you are supposed to use xmlFree instead of free

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

2020-10-08 Thread James Almer
On 10/8/2020 9:45 AM, Christopher Degawa wrote: > Use xmlFree instead of av_freep > > snip from libxml2: > > * xmlGetProp: > ... > * Returns the attribute value or NULL if not found. > * It's up to the caller to free the memory with xmlFree(). > > According to libxml2, you are supposed to

[FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

2020-10-08 Thread Christopher Degawa
Use xmlFree instead of av_freep snip from libxml2: * xmlGetProp: ... * Returns the attribute value or NULL if not found. * It's up to the caller to free the memory with xmlFree(). According to libxml2, you are supposed to use xmlFree instead of free on the pointer returned by it, and also