Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-16 Thread Daniel Kučera
> > This changes: > ./ffmpeg -y -i 'concat:matrixbench_mpeg2.mpg|matrixbench_mpeg2.mpg' -vsync 0 > -an file.avi > fixed, sending new patch. -- S pozdravom / Best regards Daniel Kucera. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread James Almer
On 10/16/2017 12:10 AM, Daniel Kučera wrote: >> This changes: >> ./ffmpeg -y -i 'concat:matrixbench_mpeg2.mpg|matrixbench_mpeg2.mpg' > -vsync 0 -an file.avi > > In case he doesn't have this sample: > http://samples.ffmpeg.org/benchmark/testsuite1/matrixbench_mpeg2.mpg > > Basically, with the patc

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread Daniel Kučera
> This changes: > ./ffmpeg -y -i 'concat:matrixbench_mpeg2.mpg|matrixbench_mpeg2.mpg' -vsync 0 -an file.avi In case he doesn't have this sample: http://samples.ffmpeg.org/benchmark/testsuite1/matrixbench_mpeg2.mpg Basically, with the patch applied the above command doesn't concatenate the input a

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread James Almer
On 10/15/2017 9:38 PM, Michael Niedermayer wrote: > On Sat, Oct 14, 2017 at 07:27:34PM +0200, Daniel Kucera wrote: >> transfer_func variable passed to retry_transfer_wrapper >> are h->prot->url_read and h->prot->url_write functions. >> These need to return EOF or other error properly. >> In case of

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread Michael Niedermayer
On Sat, Oct 14, 2017 at 07:27:34PM +0200, Daniel Kucera wrote: > transfer_func variable passed to retry_transfer_wrapper > are h->prot->url_read and h->prot->url_write functions. > These need to return EOF or other error properly. > In case of returning >= 0, url_read/url_write is retried > until e

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread Moritz Barsnick
On Sat, Oct 14, 2017 at 19:27:34 +0200, Daniel Kucera wrote: > Subject: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF > libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: > retry_transfer_wrapper: don't treat 0 as EOF Something wen

[FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-14 Thread Daniel Kucera
transfer_func variable passed to retry_transfer_wrapper are h->prot->url_read and h->prot->url_write functions. These need to return EOF or other error properly. In case of returning >= 0, url_read/url_write is retried until error is returned. Signed-off-by: Daniel Kucera --- libavformat/avio.c

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-20 Thread Michael Niedermayer
On Fri, Jun 09, 2017 at 03:39:59PM +0200, Daniel Kučera wrote: > 2017-06-05 21:18 GMT+02:00 Daniel Kucera : > > Signed-off-by: Daniel Kucera > > --- > > libavformat/cache.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/cache.c b/libavformat/cache.c

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-15 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/cache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think this is correct, but I do not maintain that file and the code has spaghetti properties. Regards, -- Nicola

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-09 Thread Daniel Kučera
2017-06-05 21:18 GMT+02:00 Daniel Kucera : > Signed-off-by: Daniel Kucera > --- > libavformat/cache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/cache.c b/libavformat/cache.c > index 6aabca2e78..66bbbf54c9 100644 > --- a/libavformat/cache.c > +++ b/li

[FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-05 Thread Daniel Kucera
Signed-off-by: Daniel Kucera --- libavformat/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cache.c b/libavformat/cache.c index 6aabca2e78..66bbbf54c9 100644 --- a/libavformat/cache.c +++ b/libavformat/cache.c @@ -201,7 +201,7 @@ static int cache_read(