Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-06-16 Thread yancen
- 原始信息 由: "Xiang, Haihao" 日期: 2019/5/27 12:53 (GMT+08:00) 收件人: rsbul...@gmail.com, ffmpeg-devel@ffmpeg.org 抄送: "Yan, CenX" 主题: Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method On Mon, 2019-05-27 at 04:44 +, Xiang, Haihao wrote: > On T

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-26 Thread Xiang, Haihao
Please ignore this email because my comment was mixed with yours. Thanks Haihao > On Thu, 2019-05-23 at 08:12 -0400, Ronald S. Bultje wrote: > Hi guys, > > On Wed, May 22, 2019 at 11:14 PM 严小复 mryan...@gmail.com>> wrote: > code”, I'm little confused about the red word,would you mean encode pro

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-26 Thread Xiang, Haihao
On Mon, 2019-05-27 at 04:44 +, Xiang, Haihao wrote: > On Thu, 2019-05-23 at 08:12 -0400, Ronald S. Bultje wrote: > Hi guys, > > On Wed, May 22, 2019 at 11:14 PM 严小复 mryan...@gmail.com>> wrote: > code”, I'm little confused about the red word,would you mean encode process > need validity checks

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-26 Thread Xiang, Haihao
On Thu, 2019-05-23 at 08:12 -0400, Ronald S. Bultje wrote: Hi guys, On Wed, May 22, 2019 at 11:14 PM 严小复 mailto:mryan...@gmail.com>> wrote: code”, I'm little confused about the red word,would you mean encode process need validity checks or there need to check the reference id of each frame? And

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-23 Thread Ronald S. Bultje
Hi guys, On Wed, May 22, 2019 at 11:14 PM 严小复 wrote: > code”, I'm little confused about the red word,would you mean encode process > need validity checks or there need to check the reference id of each frame? > > And this patch will act on decode process, all references have already been > appoi

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-22 Thread 严小复
Hi, Ronald Sorry to reply late. For you question, “we lack per-block reference validity checks in the block reconstruction code”, I'm little confused about the red word,would you mean encode process need validity checks or there need to check the reference id of each frame? And this patch wi

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-05-22 Thread Ronald S. Bultje
Hi, On Wed, May 22, 2019 at 2:12 AM Yan, CenX wrote: > Hi, Ronald > > > > Sorry to reply late. > > > > For you question, “we lack per-block reference validity checks in the > block reconstruction code”, would you mean encode process need validity > checks? > No. The decoder needs validity check

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-04-30 Thread Ronald S. Bultje
Hi, On Mon, Apr 29, 2019 at 10:03 PM Yan Cen wrote: > From: Yan Cen > > There is no need all reference frame demension is valid in libvpx. I think you're touching on a bigger issue here: libvpx allows having invalid (or even missing) references, and we don't. Note that this means we lack per-

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-04-30 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Yan Cen > Sent: Tuesday, April 30, 2019 9:46 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Yan, CenX > Subject: [FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging > method > > From

[FFmpeg-devel] [PATCH] libavcodec/vp9: fix ref-frame size judging method

2019-04-29 Thread Yan Cen
From: Yan Cen There is no need all reference frame demension is valid in libvpx. So this change contains three part: 1. Change each judgement's loglevel from "ERROR" to "WARNING" 2. Make sure at least one of frames that this frame references has valid dimension. 3. All judgements fail would rep