Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread Andrey Turkin
> No: this part of the patch does nothing because it's already unreffed in the > avcodec_close() called immediately above. Maybe the unref should actually be in > avcodec_free_context() only (if treating it like rc_override and those fields), > but it shouldn't be in both. I missed that, thank you

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread wm4
On Fri, 13 May 2016 10:58:02 +0100 Mark Thompson wrote: > On 13/05/16 10:42, wm4 wrote: > > On Fri, 13 May 2016 10:54:17 +0300 > > Andrey Turkin wrote: > > > >> 2016-05-13 10:35 GMT+03:00 wm4 : > >> > >>> On Thu, 12 May 2016 22:35:48 +0300 > >>> Andrey Turkin wrote: > >>> > Few fu

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread Mark Thompson
On 13/05/16 10:42, wm4 wrote: > On Fri, 13 May 2016 10:54:17 +0300 > Andrey Turkin wrote: > >> 2016-05-13 10:35 GMT+03:00 wm4 : >> >>> On Thu, 12 May 2016 22:35:48 +0300 >>> Andrey Turkin wrote: >>> Few functions didn't handle hw_frames_ctx references causing resources >>> leaks and eve

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread wm4
On Fri, 13 May 2016 10:54:17 +0300 Andrey Turkin wrote: > 2016-05-13 10:35 GMT+03:00 wm4 : > > > On Thu, 12 May 2016 22:35:48 +0300 > > Andrey Turkin wrote: > > > > > Few functions didn't handle hw_frames_ctx references causing resources > > leaks and even crashes. > > > --- > > > libavc

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread Andrey Turkin
2016-05-13 10:35 GMT+03:00 wm4 : > On Thu, 12 May 2016 22:35:48 +0300 > Andrey Turkin wrote: > > > Few functions didn't handle hw_frames_ctx references causing resources > leaks and even crashes. > > --- > > libavcodec/options.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff

Re: [FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-13 Thread wm4
On Thu, 12 May 2016 22:35:48 +0300 Andrey Turkin wrote: > Few functions didn't handle hw_frames_ctx references causing resources leaks > and even crashes. > --- > libavcodec/options.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavcodec/options.c b/libavcodec/options

[FFmpeg-devel] [PATCH] libavcodec/options.c: handle hw_frames_ctx where necessary

2016-05-12 Thread Andrey Turkin
Few functions didn't handle hw_frames_ctx references causing resources leaks and even crashes. --- libavcodec/options.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index ea2563b..8682262 100644 --- a/libavcodec/options.c +++ b/libavc