Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Marth64
> Agreed. I'm good too, thanks for the input. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
> > Or is there any reason to not call it what it is (Dish)? There are Sega or > Nintendo audio decoders and other examples and a cryptic description like > "DVB 0502" renders it useless for almost everybody. > Agreed. Kieran > ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Soft Works
26, 2025 1:14 AM > > > To: FFmpeg development discussions and patches > > de...@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: > rename > > > 0x0502 CC format > > > > > > > they are broadcasting using a variation

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-26 Thread Kieran Kunhya via ffmpeg-devel
ect: Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename > > 0x0502 CC format > > > > > they are broadcasting using a variation of DVB-S (there is no US > > standard for sat tv), so the current naming is actually valid. > > > > This is my understanding

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marth64 > Sent: Sunday, January 26, 2025 1:14 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename > 0x0502 C

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Marth64
> they are broadcasting using a variation of DVB-S (there is no US standard for > sat tv), so the current naming is actually valid. This is my understanding also, but I do believe there was 1 other network that used the same variation. Hence why I suggested a generic name. The counter argument fr

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Scott Theisen > Sent: Sunday, January 26, 2025 12:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename > 0x0502 CC format > > On 1/25/25 18:28, Kie

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Scott Theisen
On 1/25/25 18:28, Kieran Kunhya via ffmpeg-devel wrote: On Sat, 25 Jan 2025, 22:53 Marth64, wrote: Hello, I am to blame here for suggesting DVB_0502 as the name. I realize it was not the best choice and apologize for wasting your cycles on this. Looping in Keiran as we had discussed this ove

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Kieran Kunhya via ffmpeg-devel
On Sat, 25 Jan 2025, 22:53 Marth64, wrote: > Hello, > > I am to blame here for suggesting DVB_0502 as the name. > I realize it was not the best choice and apologize for wasting your > cycles on this. > > Looping in Keiran as we had discussed this over IRC briefly a few weeks > back. > As I don't

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Marth64
Hello, I am to blame here for suggesting DVB_0502 as the name. I realize it was not the best choice and apologize for wasting your cycles on this. Looping in Keiran as we had discussed this over IRC briefly a few weeks back. As I don't know how many networks actually use this in the wild, it coul

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Marton Balint
On Sat, 25 Jan 2025, Scott Theisen wrote: The format is used by at least one DVB-S provider, but is not defined in any DVB standard, so remove references to DVB. Since I don't have any standard that does define this format, using the magic number as the name seems most appropriate. This is

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-01-25 Thread Scott Theisen
The format is used by at least one DVB-S provider, but is not defined in any DVB standard, so remove references to DVB. Since I don't have any standard that does define this format, using the magic number as the name seems most appropriate. This is a simple rename, no functional change. Th