Re: [FFmpeg-devel] [PATCH] libavcodec/iff: Use unsigned to avoid undefined behaviour

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 03:43:23PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: P

Re: [FFmpeg-devel] [PATCH] libavcodec/iff: Use unsigned to avoid undefined behaviour

2019-08-05 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavcodec/iff: Use unsigned to avoid undefined behaviour

2019-08-02 Thread Andreas Rheinhardt
The initialization of the uint32_t plane32_lut matrix uses left shifts of the form 1 << plane; plane can be as big as 31 which means that this is undefined behaviour as 1 will be simply an int. So make it unsigned to avoid this. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 34 +++