tis 2024-01-23 klockan 00:40 +0300 skrev Victor Luchitz:
> On Tue, Jan 23, 2024 at 12:12 AM Tomas Härdin wrote:
>
> > mån 2024-01-22 klockan 22:14 +0300 skrev Victor Luchits:
> > > The bitrate option (-b:v) can now be used to specify the bit rate
> > > of the video stream of the RoQ encoder.
> >
Typo in commit message: liavcodec should be libavcodec
On 22 Jan 2024, at 20:14, Victor Luchits wrote:
> The bitrate option (-b:v) can now be used to specify the bit rate
> of the video stream of the RoQ encoder.
>
> Original patch by Joseph Fenton aka Chilly Willy
>
> Signed-off-by: Victor Luchi
On Tue, Jan 23, 2024 at 12:12 AM Tomas Härdin wrote:
> mån 2024-01-22 klockan 22:14 +0300 skrev Victor Luchits:
> > The bitrate option (-b:v) can now be used to specify the bit rate
> > of the video stream of the RoQ encoder.
> >
> > Original patch by Joseph Fenton aka Chilly Willy
> >
> > Signed
mån 2024-01-22 klockan 22:14 +0300 skrev Victor Luchits:
> The bitrate option (-b:v) can now be used to specify the bit rate
> of the video stream of the RoQ encoder.
>
> Original patch by Joseph Fenton aka Chilly Willy
>
> Signed-off-by: Victor Luchits
Still doesn't apply.
> +/* Keyframe
I've just posted a new version of the patch that addresses most (if not
all) of the comments from previous reviews.
On Mon, Jan 22, 2024 at 10:10 PM Tomas Härdin wrote:
> mån 2024-01-22 klockan 21:32 +0300 skrev Victor Luchitz:
> > On Mon, Jan 22, 2024 at 4:57 PM Tomas Härdin wrote:
> >
> > > >
The bitrate option (-b:v) can now be used to specify the bit rate
of the video stream of the RoQ encoder.
Original patch by Joseph Fenton aka Chilly Willy
Signed-off-by: Victor Luchits
---
Changelog| 1 +
libavcodec/roqvideo.h| 1 +
libavcodec/roqvideodec.c | 16 ++
mån 2024-01-22 klockan 21:32 +0300 skrev Victor Luchitz:
> On Mon, Jan 22, 2024 at 4:57 PM Tomas Härdin wrote:
>
> > > >
> > > > > - if (frame->quality)
> > > > > - enc->lambda = frame->quality - 1;
> > > > > - else
> > > > > - enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > > > > +
On Mon, Jan 22, 2024 at 4:57 PM Tomas Härdin wrote:
> > >
> > > > -if (frame->quality)
> > > > -enc->lambda = frame->quality - 1;
> > > > -else
> > > > -enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > > > +if (avctx->bit_rate <= ROQ_DEFAULT_MIN_BIT_RATE) {
> > > > +/* n
The rationale behind the bit_rate check is that RoQ was originally
designed with early CD-ROM games in mind (The 7th Guest, The
11th Hour), thus the lowest bit_rate that would make any sense in
that context should be based around that. You really want to get
the best picture quality without exceedi
Thanks, I will look into it
On Mon, Jan 22, 2024 at 4:59 PM Martin Storsjö wrote:
> On Mon, 22 Jan 2024, Tomas Härdin wrote:
>
> >>> >>> -if (frame->quality)
> >> > > -enc->lambda = frame->quality - 1;
> >> > > -else
> >> > > -enc->lambda = 2*ROQ_LAMBDA_SCALE;
> >> > > +
mån 2024-01-22 klockan 15:59 +0200 skrev Martin Storsjö:
> On Mon, 22 Jan 2024, Tomas Härdin wrote:
>
> > > > > > > - if (frame->quality)
> > > > > - enc->lambda = frame->quality - 1;
> > > > > - else
> > > > > - enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > > > > + if (avctx->bit_
On Mon, 22 Jan 2024, Tomas Härdin wrote:
>>> - if (frame->quality)
> > - enc->lambda = frame->quality - 1;
> > - else
> > - enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > + if (avctx->bit_rate <= ROQ_DEFAULT_MIN_BIT_RATE) {
> > + /* no specific bit rate desired, use frame
> >
> > > - if (frame->quality)
> > > - enc->lambda = frame->quality - 1;
> > > - else
> > > - enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > > + if (avctx->bit_rate <= ROQ_DEFAULT_MIN_BIT_RATE) {
> > > + /* no specific bit rate desired, use frame quality */
> > > + if
On Mon, Jan 22, 2024 at 4:06 PM Tomas Härdin wrote:
> mån 2024-01-22 klockan 00:08 +0300 skrev Victor Luchits:
> > One can now use the bitrate option (-b) to specify bit rate of the
> > video
> > stream in the RoQ encoder. The option only becomes effective for
> > values
> > above 800kbit/s, whic
mån 2024-01-22 klockan 00:08 +0300 skrev Victor Luchits:
> One can now use the bitrate option (-b) to specify bit rate of the
> video
> stream in the RoQ encoder. The option only becomes effective for
> values
> above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-
> speed
> CD-ROM dri
One can now use the bitrate option (-b) to specify bit rate of the video
stream in the RoQ encoder. The option only becomes effective for values
above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-speed
CD-ROM drive, minus the bandwidth taken up by stereo DPCM stream. Values
below th
On Sun, Jan 21, 2024 at 11:19:43PM +0300, Victor Luchits wrote:
> One can now use the bitrate option (-b) to specify bit rate of the video
> stream in the RoQ encoder. The option only becomes effective for values
> above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-speed
> CD-ROM dri
One can now use the bitrate option (-b) to specify bit rate of the video
stream in the RoQ encoder. The option only becomes effective for values
above 800kbit/s, which is roughly equivalent to bandwidth of a 1x-speed
CD-ROM drive, minus the bandwidth taken up by stereo DPCM stream. Values
below th
18 matches
Mail list logo
