Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Lynne via ffmpeg-devel
On 26/07/2024 11:03, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: On 26/07/2024 10:22, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: Its not feasible to add an AVClass in the main context, as it would waste space, as the main context is recursive, and every bit of assembly would need

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Andreas Rheinhardt
Lynne via ffmpeg-devel: > On 26/07/2024 10:22, Andreas Rheinhardt wrote: >> Lynne via ffmpeg-devel: >>> Its not feasible to add an AVClass in the main context, as >>> it would waste space, as the main context is recursive, and >>> every bit of assembly would need to be changed. >>> >>> While its tr

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Anton Khirnov
Quoting Lynne via ffmpeg-devel (2024-07-26 10:33:24) > On 26/07/2024 09:47, Anton Khirnov wrote: > > Quoting Lynne via ffmpeg-devel (2024-07-26 08:42:11) > >> Its not feasible to add an AVClass in the main context, as > >> it would waste space, as the main context is recursive, and > >> every bit o

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Zhao Zhili
> On Jul 26, 2024, at 14:42, Lynne via ffmpeg-devel > wrote: > > Its not feasible to add an AVClass in the main context, as > it would waste space, as the main context is recursive, and > every bit of assembly would need to be changed. > > While its true that on paper av_log has access to the

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Lynne via ffmpeg-devel
On 26/07/2024 09:47, Anton Khirnov wrote: Quoting Lynne via ffmpeg-devel (2024-07-26 08:42:11) Its not feasible to add an AVClass in the main context, as it would waste space, as the main context is recursive, and every bit of assembly would need to be changed. While its true that on paper av_l

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Lynne via ffmpeg-devel
On 26/07/2024 10:22, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: Its not feasible to add an AVClass in the main context, as it would waste space, as the main context is recursive, and every bit of assembly would need to be changed. While its true that on paper av_log has access to the mai

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Andreas Rheinhardt
Lynne via ffmpeg-devel: > Its not feasible to add an AVClass in the main context, as > it would waste space, as the main context is recursive, and > every bit of assembly would need to be changed. > > While its true that on paper av_log has access to the main > context, that functionality is not u

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-26 Thread Anton Khirnov
Quoting Lynne via ffmpeg-devel (2024-07-26 08:42:11) > Its not feasible to add an AVClass in the main context, as > it would waste space, as the main context is recursive, and > every bit of assembly would need to be changed. > > While its true that on paper av_log has access to the main > context

[FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2024-07-25 Thread Lynne via ffmpeg-devel
Its not feasible to add an AVClass in the main context, as it would waste space, as the main context is recursive, and every bit of assembly would need to be changed. While its true that on paper av_log has access to the main context, that functionality is not used as no options are available for

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-28 Thread Anton Khirnov
Quoting Lynne (2023-05-28 04:48:00) > May 28, 2023, 03:07 by jamr...@gmail.com: > > > On 5/24/2023 9:32 PM, Lynne wrote: > > > >> May 24, 2023, 23:24 by leo.i...@gmail.com: > >> > >>> On 5/24/23 16:35, Lynne wrote: > >>> > Patch attached. > > >>> > >>> +av_log((void *)&tx_class, AV_L

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-27 Thread Lynne
May 28, 2023, 03:07 by jamr...@gmail.com: > On 5/24/2023 9:32 PM, Lynne wrote: > >> May 24, 2023, 23:24 by leo.i...@gmail.com: >> >>> On 5/24/23 16:35, Lynne wrote: >>> Patch attached. >>> >>> +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); >>> >>> The type of the first arg

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-27 Thread James Almer
On 5/24/2023 9:32 PM, Lynne wrote: May 24, 2023, 23:24 by leo.i...@gmail.com: On 5/24/23 16:35, Lynne wrote: Patch attached. +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); The type of the first argument to av_log should be AVClass **, but this only appears to be AVClass *.

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-24 Thread Lynne
May 24, 2023, 23:24 by leo.i...@gmail.com: > On 5/24/23 16:35, Lynne wrote: > >> Patch attached. >> > > +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); > > The type of the first argument to av_log should be AVClass **, but this only > appears to be AVClass *. See libavutil/log.c lin

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-24 Thread Leo Izen
On 5/24/23 16:35, Lynne wrote: Patch attached. +av_log((void *)&tx_class, AV_LOG_DEBUG, "%s\n", bp.str); The type of the first argument to av_log should be AVClass **, but this only appears to be AVClass *. See libavutil/log.c line 428. - Leo Izen __

Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-24 Thread Paul B Mahol
On 5/24/23, Lynne wrote: > Patch attached. > > Probably fine. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, )

2023-05-24 Thread Lynne
Patch attached. >From 2813dcb5b885bdf0c3f78f8aead43f4b11149a70 Mon Sep 17 00:00:00 2001 From: Lynne Date: Wed, 24 May 2023 21:57:25 +0200 Subject: [PATCH] lavu/tx: stop using av_log(NULL, ) --- libavutil/tx.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/