Re: [FFmpeg-devel] [PATCH] lavu/opt: handle NULL during class comparsion

2014-12-03 Thread Lukasz Marek
On 3 December 2014 at 14:29, Lukasz Marek wrote: > > On 3 December 2014 at 14:10, Michael Niedermayer wrote: > >> On Wed, Dec 03, 2014 at 12:06:18AM +0100, Lukasz Marek wrote: >> > av_opt_copy compares classes to avoid copying between mismatched >> objects. >> > This protection fails when dest c

Re: [FFmpeg-devel] [PATCH] lavu/opt: handle NULL during class comparsion

2014-12-03 Thread Lukasz Marek
On 3 December 2014 at 14:10, Michael Niedermayer wrote: > On Wed, Dec 03, 2014 at 12:06:18AM +0100, Lukasz Marek wrote: > > av_opt_copy compares classes to avoid copying between mismatched objects. > > This protection fails when dest class is NULL. > > does this case actually occur ? > Yes and n

Re: [FFmpeg-devel] [PATCH] lavu/opt: handle NULL during class comparsion

2014-12-03 Thread Michael Niedermayer
On Wed, Dec 03, 2014 at 12:06:18AM +0100, Lukasz Marek wrote: > av_opt_copy compares classes to avoid copying between mismatched objects. > This protection fails when dest class is NULL. does this case actually occur ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0

[FFmpeg-devel] [PATCH] lavu/opt: handle NULL during class comparsion

2014-12-02 Thread Lukasz Marek
av_opt_copy compares classes to avoid copying between mismatched objects. This protection fails when dest class is NULL. Signed-off-by: Lukasz Marek --- libavutil/opt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index d873bd2..0e42f