Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-27 Thread Ganesh Ajjanagadde
On Sun, Dec 27, 2015 at 5:38 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 24, 2015 at 1:32 PM, Ganesh Ajjanagadde > wrote: >> >> In the standard library, these are functions. We should match it; there >> is no reason for these to be macros. >> >> While at it, add some trivial comments for re

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-27 Thread Ronald S. Bultje
Hi, On Thu, Dec 24, 2015 at 1:32 PM, Ganesh Ajjanagadde wrote: > In the standard library, these are functions. We should match it; there > is no reason for these to be macros. > > While at it, add some trivial comments for readability and correct an > incorrect (at standard double precision) M_L

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-27 Thread wm4
On Thu, 24 Dec 2015 19:52:21 +0100 Hendrik Leppkes wrote: > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > > > > In the standard library, these are functions. We should match it; there > > is no reason for these to be macros. > > > > While at it, add some trivial comments for readability an

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 11:05 AM, Hendrik Leppkes wrote: > Am 24.12.2015 20:01 schrieb "Ganesh Ajjanagadde" : >> >> On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes > wrote: >> > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" >: >> >> >> >> In the standard library, these are functions. We shou

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Hendrik Leppkes
Am 24.12.2015 20:01 schrieb "Ganesh Ajjanagadde" : > > On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes wrote: > > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > >> > >> In the standard library, these are functions. We should match it; there > >> is no reason for these to be macros. > >> >

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes wrote: > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : >> >> In the standard library, these are functions. We should match it; there >> is no reason for these to be macros. >> >> While at it, add some trivial comments for readability and corre

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Hendrik Leppkes
Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > > In the standard library, these are functions. We should match it; there > is no reason for these to be macros. > > While at it, add some trivial comments for readability and correct an > incorrect (at standard double precision) M_LN2 constant u

[FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
In the standard library, these are functions. We should match it; there is no reason for these to be macros. While at it, add some trivial comments for readability and correct an incorrect (at standard double precision) M_LN2 constant used in the exp2 fallback. Signed-off-by: Ganesh Ajjanagadde