Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-16 Thread Pavel Koshevoy
On Sat, Nov 16, 2024 at 9:00 AM James Almer wrote: > On 11/16/2024 12:57 PM, Pavel Koshevoy wrote: > > On Fri, Nov 15, 2024 at 9:25 PM Anton Khirnov wrote: > > > >> Quoting Pavel Koshevoy (2024-11-15 20:32:21) > >>> This avoids unpleasant surprises to av_frame_get_buffer callers > >>> that expli

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-16 Thread Pavel Koshevoy
On Sat, Nov 16, 2024 at 9:25 AM Pavel Koshevoy wrote: > > > On Sat, Nov 16, 2024 at 9:00 AM James Almer wrote: > >> On 11/16/2024 12:57 PM, Pavel Koshevoy wrote: >> > On Fri, Nov 15, 2024 at 9:25 PM Anton Khirnov >> wrote: >> > >> >> Quoting Pavel Koshevoy (2024-11-15 20:32:21) >> >>> This avoi

[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v3)

2024-11-16 Thread Pavel Koshevoy
This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. For example, see https://github.com/sekrit-twc/zimg/issues/212 Although the zscale issue has already been resolved by other me

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-16 Thread James Almer
On 11/16/2024 12:57 PM, Pavel Koshevoy wrote: On Fri, Nov 15, 2024 at 9:25 PM Anton Khirnov wrote: Quoting Pavel Koshevoy (2024-11-15 20:32:21) This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-16 Thread Pavel Koshevoy
On Fri, Nov 15, 2024 at 9:25 PM Anton Khirnov wrote: > Quoting Pavel Koshevoy (2024-11-15 20:32:21) > > This avoids unpleasant surprises to av_frame_get_buffer callers > > that explicitly specified 64-byte alignment and didn't get > > AVFrame.data pointers that are 64-byte aligned. > > > > For ex

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-16 Thread Anton Khirnov
Quoting Pavel Koshevoy (2024-11-09 18:46:53) > AVFrame.data pointers being aligned according to the explicitly specified > align parameter > is not going to break any caller. It is a safe change, and I would think > a welcome change for any users of av_frame_get_buffer. I agree and am in favor of

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-15 Thread Anton Khirnov
Quoting Pavel Koshevoy (2024-11-15 20:32:21) > This avoids unpleasant surprises to av_frame_get_buffer callers > that explicitly specified 64-byte alignment and didn't get > AVFrame.data pointers that are 64-byte aligned. > > For example, see https://github.com/sekrit-twc/zimg/issues/212 > > Alth

[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers (v2)

2024-11-15 Thread Pavel Koshevoy
This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. For example, see https://github.com/sekrit-twc/zimg/issues/212 Although the zscale issue has already been resolved by other me

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-15 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:46 AM Pavel Koshevoy wrote: > > > On Sat, Nov 9, 2024 at 10:39 AM James Almer wrote: > >> On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: >> > On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: >> > >> >> On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: >> >>> This avoids unple

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:39 AM James Almer wrote: > On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: > > On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: > > > >> On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: > >>> This avoids unpleasant surprises to av_frame_get_buffer callers > >>> that explicitly

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread James Almer
On 11/9/2024 2:34 PM, Pavel Koshevoy wrote: On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
On Sat, Nov 9, 2024 at 10:27 AM James Almer wrote: > On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: > > This avoids unpleasant surprises to av_frame_get_buffer callers > > that explicitly specified 64-byte alignment and didn't get > > AVFrame.data pointers that are 64-byte aligned. > > Again, the do

Re: [FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread James Almer
On 11/9/2024 1:57 PM, Pavel Koshevoy wrote: This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. Again, the doxy is clear that only the buffer sizes are aligned, not the pointe

[FFmpeg-devel] [PATCH] lavu/get_video_buffer: also align data pointers

2024-11-09 Thread Pavel Koshevoy
This avoids unpleasant surprises to av_frame_get_buffer callers that explicitly specified 64-byte alignment and didn't get AVFrame.data pointers that are 64-byte aligned. In particular, this fixes an issue in vf_zscale. https://github.com/sekrit-twc/zimg/issues/212 --- libavutil/frame.c | 4 +++-