Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 07:24:43PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-09): > > Patch is incomplete, incorrect and defamatory thus rejected. Dealt with it. > > Patch is as complete as I can make it, and it is accurate, and therefore > your accusation of "defamatory" are the defam

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Nicolas George
Paul B Mahol (12020-09-09): > Patch is incomplete, incorrect and defamatory thus rejected. Dealt with it. Patch is as complete as I can make it, and it is accurate, and therefore your accusation of "defamatory" are the defamatory parts in this discussion. > Rubberband filter need to know that las

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 06:44:44PM +0200, Nicolas George wrote: > Paul B Mahol (12020-09-09): > > Patch rejected. There is no need to fix what is not broken. > > Rejection rejected. I have explained exactly why it is broken, you have > not addressed it at all. Patch is incomplete, incorrect and d

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Nicolas George
Paul B Mahol (12020-09-09): > Patch rejected. There is no need to fix what is not broken. Rejection rejected. I have explained exactly why it is broken, you have not addressed it at all. -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 04:58:35PM +0200, Nicolas George wrote: > The link API provides an abstraction, where a filter sees on an > input a stream of frames or samples terminated by a status change. > Calling ff_outlink functions on an input bypasses this abstraction > to peek inside implementation

[FFmpeg-devel] [PATCH] lavfi: flag incorrect uses of ff_outlink APIs.

2020-09-09 Thread Nicolas George
The link API provides an abstraction, where a filter sees on an input a stream of frames or samples terminated by a status change. Calling ff_outlink functions on an input bypasses this abstraction to peek inside implementation details; it may work now, but it can break at any point if the implemen