Re: [FFmpeg-devel] [PATCH] lavfi/zoomoan: fix frame count logic

2014-12-06 Thread Paul B Mahol
On 12/1/14, Nicolas George wrote: > I prefer first patch, as it makes the code simpler and starting at 0 > simplifies all arithmetic operations, but it makes a slight behaviour > change, so I also propose the second version. Note how the 1-indexed logic > makes the documentation for "on" awkward.

Re: [FFmpeg-devel] [PATCH] lavfi/zoomoan: fix frame count logic

2014-12-06 Thread Clément Bœsch
On Mon, Dec 01, 2014 at 04:25:42PM +0100, Nicolas George wrote: > I prefer first patch, as it makes the code simpler and starting at 0 > simplifies all arithmetic operations, but it makes a slight behaviour > change, so I also propose the second version. Note how the 1-indexed logic > makes the doc

Re: [FFmpeg-devel] [PATCH] lavfi/zoomoan: fix frame count logic

2014-12-06 Thread Michael Niedermayer
On Mon, Dec 01, 2014 at 04:25:42PM +0100, Nicolas George wrote: > I prefer first patch, as it makes the code simpler and starting at 0 > simplifies all arithmetic operations, but it makes a slight behaviour > change, so I also propose the second version. Note how the 1-indexed logic > makes the doc

[FFmpeg-devel] [PATCH] lavfi/zoomoan: fix frame count logic

2014-12-01 Thread Nicolas George
I prefer first patch, as it makes the code simpler and starting at 0 simplifies all arithmetic operations, but it makes a slight behaviour change, so I also propose the second version. Note how the 1-indexed logic makes the documentation for "on" awkward. Regards, -- Nicolas George From e6bce5