Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-20 Thread Carl Eugen Hoyos
2018-08-20 19:09 GMT+02:00, Paul B Mahol : > On 8/20/18, Carl Eugen Hoyos wrote: >> 2018-08-20 7:15 GMT+02:00, Gyan Doshi : >>> On 20-08-2018 03:17 AM, Carl Eugen Hoyos wrote: > We have -filter_complex_threads for that, so no. For which use-case is this an advantage? >>> >>> For whe

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-20 Thread Paul B Mahol
On 8/20/18, Carl Eugen Hoyos wrote: > 2018-08-20 7:15 GMT+02:00, Gyan Doshi : >> On 20-08-2018 03:17 AM, Carl Eugen Hoyos wrote: >> >>> I believe that if a general option exists (as in this case), it is a bad >>> idea to have a specifically targeted option that has to be used instead. >> >> The us

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-20 Thread Carl Eugen Hoyos
2018-08-20 7:15 GMT+02:00, Gyan Doshi : > On 20-08-2018 03:17 AM, Carl Eugen Hoyos wrote: > >> I believe that if a general option exists (as in this case), it is a bad >> idea to have a specifically targeted option that has to be used instead. > > The user may not want the thread pool to be availab

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-19 Thread Gyan Doshi
On 20-08-2018 03:17 AM, Carl Eugen Hoyos wrote: I believe that if a general option exists (as in this case), it is a bad idea to have a specifically targeted option that has to be used instead. The user may not want the thread pool to be available for any other threaded filters in the graph.

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-19 Thread Carl Eugen Hoyos
2018-08-17 15:15 GMT+02:00, Gyan Doshi : > > > On 17-08-2018 06:12 PM, Carl Eugen Hoyos wrote: >> 2018-08-14 9:57 GMT+02:00, Gyan Doshi : > > > filter_threads applies to all simple filtergraphs. The private option > is specifically targeted. Isn't that better? >> >> I believe the opposi

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-17 Thread Gyan Doshi
On 17-08-2018 06:12 PM, Carl Eugen Hoyos wrote: 2018-08-14 9:57 GMT+02:00, Gyan Doshi : filter_threads applies to all simple filtergraphs. The private option is specifically targeted. Isn't that better? I believe the opposite is true. Which - preference for private option or application

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-17 Thread Carl Eugen Hoyos
2018-08-14 9:57 GMT+02:00, Gyan Doshi : > > > On 14-08-2018 01:20 PM, Paul B Mahol wrote: >> On 8/14/18, Gyan Doshi wrote: >>> >>> >>> On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: >>> >> >> Why does this not use -filter_threads? > > > Didn't know it was an option. >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-14 Thread Gyan Doshi
On 14-08-2018 01:20 PM, Paul B Mahol wrote: On 8/14/18, Gyan Doshi wrote: On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: Why does this not use -filter_threads? Didn't know it was an option. I can certainly change the code to use it. Please do it if it works. filter_threads app

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-14 Thread Paul B Mahol
On 8/14/18, Gyan Doshi wrote: > > > On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: > Why does this not use -filter_threads? >>> >>> >>> Didn't know it was an option. >> >>> I can certainly change the code to use it. >> >> Please do it if it works. > > filter_threads applies to all simpl

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Gyan Doshi
On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: Why does this not use -filter_threads? Didn't know it was an option. I can certainly change the code to use it. Please do it if it works. filter_threads applies to all simple filtergraphs. The private option is specifically targeted.

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Carl Eugen Hoyos
2018-08-13 23:12 GMT+02:00, Kyle Swanson : > Hi, > > On Mon, Aug 13, 2018 at 11:56 AM, Carl Eugen Hoyos > wrote: > >> 2018-08-08 0:37 GMT+02:00, Kyle Swanson : >> >> > +{"n_threads", "Set number of threads to be used when computing >> vmaf.", >> > OFFSET(n_threads), AV_OPT_TYPE_INT

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Kyle Swanson
Hi, On Mon, Aug 13, 2018 at 11:56 AM, Carl Eugen Hoyos wrote: > 2018-08-08 0:37 GMT+02:00, Kyle Swanson : > > > +{"n_threads", "Set number of threads to be used when computing > vmaf.", > > OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX, > > FLAGS}, > > Why does this n

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-13 Thread Carl Eugen Hoyos
2018-08-08 0:37 GMT+02:00, Kyle Swanson : > +{"n_threads", "Set number of threads to be used when computing vmaf.", > OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX, > FLAGS}, Why does this not use -filter_threads? Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-10 Thread Kyle Swanson
Hi, > On Aug 9, 2018, at 10:10 AM, Kyle Swanson wrote: > > Hi, > >> On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: >> From: Kyle Swanson >> >> Signed-off-by: Kyle Swanson >> --- >> configure| 2 +- >> libavfilter/vf_libvmaf.c | 9 - >> 2 files changed, 9 insert

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-09 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 3:37 PM, Kyle Swanson wrote: > From: Kyle Swanson > > Signed-off-by: Kyle Swanson > --- > configure| 2 +- > libavfilter/vf_libvmaf.c | 9 - > 2 files changed, 9 insertions(+), 2 deletions(-) > > I'll update docs and push this sometime in the

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-08 Thread Carl Eugen Hoyos
2018-08-08 5:02 GMT+02:00, James Almer : > It would be ideal if this library could stop breaking the API so often. Not that I care much but don't we have a requirement for external libs to have a stable api? Carl Eugen ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
Hi, On Tue, Aug 7, 2018 at 8:02 PM, James Almer wrote: > On 8/7/2018 7:37 PM, Kyle Swanson wrote: > > From: Kyle Swanson > > > > Signed-off-by: Kyle Swanson > > --- > > configure| 2 +- > > libavfilter/vf_libvmaf.c | 9 - > > 2 files changed, 9 insertions(+), 2 deletio

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread James Almer
On 8/7/2018 7:37 PM, Kyle Swanson wrote: > From: Kyle Swanson > > Signed-off-by: Kyle Swanson > --- > configure| 2 +- > libavfilter/vf_libvmaf.c | 9 - > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 15a58935de..e718c15

[FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-07 Thread Kyle Swanson
From: Kyle Swanson Signed-off-by: Kyle Swanson --- configure| 2 +- libavfilter/vf_libvmaf.c | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 15a58935de..e718c1531c 100755 --- a/configure +++ b/configure @@ -6089,7 +6089,7