Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-17 Thread Nicolas George
Le tridi 23 messidor, an CCXXV, Paul B Mahol a écrit : > You never asked for one. Indeed, since I forgot to answer your mail. But you know what is necessary in a bug report. > Here it is attached just for you. I think you sent it to the mailing-list, not just to me. Anyway, I have a working ver

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-11 Thread Paul B Mahol
On 7/11/17, Nicolas George wrote: > Le tridi 23 messidor, an CCXXV, Paul B Mahol a ecrit : >> Nothing can get rid of that issue, except tootal lavfi rewrite. > > Why do you say that? My plan gets rid of them quite easily, since now > all links have a dynamically-sized FIFO built-in. > >> I tried t

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-11 Thread Nicolas George
Le tridi 23 messidor, an CCXXV, Paul B Mahol a écrit : > Nothing can get rid of that issue, except tootal lavfi rewrite. Why do you say that? My plan gets rid of them quite easily, since now all links have a dynamically-sized FIFO built-in. > I tried this and it did not work at all. And I even co

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-11 Thread Paul B Mahol
On 7/11/17, Nicolas George wrote: > Le primidi 21 messidor, an CCXXV, Marton Balint a ecrit : >> I am not saying they aren't, I'm just showing a case where your revert is >> breaking another case which was working before. Nicolas also stated there >> can be cases where the old code (before the rev

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-11 Thread Nicolas George
Le primidi 21 messidor, an CCXXV, Marton Balint a écrit : > I am not saying they aren't, I'm just showing a case where your revert is > breaking another case which was working before. Nicolas also stated there > can be cases where the old code (before the revert) worked better. I just > hope that I

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : The reverted commit breaks lot of filter

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Paul B Mahol
On 7/9/17, Marton Balint wrote: > > On Sun, 9 Jul 2017, Paul B Mahol wrote: > >> On 7/9/17, Marton Balint wrote: >>> >>> On Sat, 24 Jun 2017, Nicolas George wrote: >>> Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : > The reverted commit breaks lot of filters and I failed to find

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : The reverted commit breaks lot of filters and I failed to find fix, the only logical solution It breaks a corner-cas

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Paul B Mahol
On 7/9/17, Marton Balint wrote: > > On Sat, 24 Jun 2017, Nicolas George wrote: > >> Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : >>> The reverted commit breaks lot of filters and I failed to find fix, >>> the only logical solution >> >> It breaks a corner-case option of, indeed a lot of

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a écrit : The reverted commit breaks lot of filters and I failed to find fix, the only logical solution It breaks a corner-case option of, indeed a lot of, filters. I have not yet been able to track down

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Nicolas George
Le sextidi 6 messidor, an CCXXV, Paul B Mahol a écrit : > The reverted commit breaks lot of filters and I failed to find fix, > the only logical solution It breaks a corner-case option of, indeed a lot of, filters. I have not yet been able to track down the exact cause of the problem, I still have

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2017 at 05:06:41PM +0200, Michael Niedermayer wrote: > On Sat, Jun 24, 2017 at 04:54:38PM +0200, Michael Niedermayer wrote: > > On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: > > > On 12/24/16, Nicolas George wrote: > > > > Le quartidi 4 nivose, an CCXXV, Michael Nie

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2017 at 05:12:34PM +0200, Paul B Mahol wrote: > On 6/24/17, Michael Niedermayer wrote: > > On Sat, Jun 24, 2017 at 04:54:38PM +0200, Michael Niedermayer wrote: > >> On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: > >> > On 12/24/16, Nicolas George wrote: > >> > > Le

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2017 at 04:54:38PM +0200, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: > > On 12/24/16, Nicolas George wrote: > > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : > > >> theres a change with "-af apad=pad_len=1 -short

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Paul B Mahol
On 6/24/17, Michael Niedermayer wrote: > On Sat, Jun 24, 2017 at 04:54:38PM +0200, Michael Niedermayer wrote: >> On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: >> > On 12/24/16, Nicolas George wrote: >> > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : >> > >> there

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2017 at 04:54:38PM +0200, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: > > On 12/24/16, Nicolas George wrote: > > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : > > >> theres a change with "-af apad=pad_len=1 -short

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-24 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 07:59:26PM +0200, Paul B Mahol wrote: > On 12/24/16, Nicolas George wrote: > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : > >> theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) > >> the file is not sharable, this change undoes the effe

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-20 Thread Gyan
On Tue, Jun 20, 2017 at 11:29 PM, Paul B Mahol wrote: > On 12/24/16, Nicolas George wrote: > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : > >> theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) > >> the file is not sharable, this change undoes the effect of

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-20 Thread Paul B Mahol
On 12/24/16, Nicolas George wrote: > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : >> theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) >> the file is not sharable, this change undoes the effect of the >> non-recursive patch >> >> use of vframes generally shows

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) > the file is not sharable, this change undoes the effect of the > non-recursive patch > > use of vframes generally shows differences which seem to return to what >

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-24 Thread Michael Niedermayer
On Sat, Dec 24, 2016 at 10:39:58AM +0100, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > > deadlocks > > > > ./ffmpeg -i mpegts_with_dvbsubs.ts -filter_complex > > '[#0xf30]scale=320:240:flags=bilinear[sub];[#0xfa8]scale=320:240:flags=bilinear[video];[vi

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXV, Michael Niedermayer a écrit : > deadlocks > > ./ffmpeg -i mpegts_with_dvbsubs.ts -filter_complex > '[#0xf30]scale=320:240:flags=bilinear[sub];[#0xfa8]scale=320:240:flags=bilinear[video];[video][sub]overlay[v]' > -map '[v]' -map '#0x1048' -t 1 a.mkv > > http://s

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-23 Thread Michael Niedermayer
On Sat, Dec 24, 2016 at 03:18:11AM +0100, Michael Niedermayer wrote: > On Sat, Dec 24, 2016 at 03:10:28AM +0100, Michael Niedermayer wrote: > > On Fri, Dec 23, 2016 at 09:49:52PM +0100, Nicolas George wrote: > > > Reduce peak memory consumption with ffmpeg in certain cases. > > > > > > Signed-off-

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-23 Thread Michael Niedermayer
On Sat, Dec 24, 2016 at 03:10:28AM +0100, Michael Niedermayer wrote: > On Fri, Dec 23, 2016 at 09:49:52PM +0100, Nicolas George wrote: > > Reduce peak memory consumption with ffmpeg in certain cases. > > > > Signed-off-by: Nicolas George > > --- > > libavfilter/buffersrc.c | 25 +

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-23 Thread Michael Niedermayer
On Fri, Dec 23, 2016 at 09:49:52PM +0100, Nicolas George wrote: > Reduce peak memory consumption with ffmpeg in certain cases. > > Signed-off-by: Nicolas George > --- > libavfilter/buffersrc.c | 25 + > 1 file changed, 25 insertions(+) deadlocks ./ffmpeg -i mpegts_with_

[FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2016-12-23 Thread Nicolas George
Reduce peak memory consumption with ffmpeg in certain cases. Signed-off-by: Nicolas George --- libavfilter/buffersrc.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index 1314397a32..77fd174219 100644 --- a/libavf