Re: [FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

2016-12-29 Thread Michael Niedermayer
On Thu, Dec 29, 2016 at 01:42:26PM -0800, Sasi Inguva wrote: > Sorry for the late review. this patch seems ok to me. applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what

Re: [FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

2016-12-29 Thread Sasi Inguva
Sorry for the late review. this patch seems ok to me. On Wed, Dec 14, 2016 at 7:34 PM, Michael Niedermayer wrote: > On Wed, Dec 14, 2016 at 03:38:18PM -0800, Matthew Wolenetz wrote: > > In ff_index_search_timestamp(), if b == num_entries, > > m == num_entries - 1, and entries[m].flags & AVINDEX_D

Re: [FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

2016-12-14 Thread Michael Niedermayer
On Wed, Dec 14, 2016 at 03:38:18PM -0800, Matthew Wolenetz wrote: > In ff_index_search_timestamp(), if b == num_entries, > m == num_entries - 1, and entries[m].flags & AVINDEX_DISCARD_FRAME is > true, then the search for the next non-discarded packet could access > entries[nb_entries], exceeding it

[FFmpeg-devel] [PATCH] lavf/utils.c Protect against accessing entries[nb_entries]

2016-12-14 Thread Matthew Wolenetz
In ff_index_search_timestamp(), if b == num_entries, m == num_entries - 1, and entries[m].flags & AVINDEX_DISCARD_FRAME is true, then the search for the next non-discarded packet could access entries[nb_entries], exceeding its bounds. This change adds a protection against that scenario. Reference: