Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread Michael Niedermayer
On Tue, Aug 19, 2014 at 01:39:33PM -0300, James Almer wrote: > On 19/08/14 7:07 AM, Michael Niedermayer wrote: > > is photometric guranteed to match the pix_fmt ? > > > > iam asking as i dont see that being ensured by the code but i might > > be missing something > > if they could mismatch, id assu

Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread James Almer
On 19/08/14 7:07 AM, Michael Niedermayer wrote: > is photometric guranteed to match the pix_fmt ? > > iam asking as i dont see that being ensured by the code but i might > be missing something > if they could mismatch, id assume it might crash TIFF_PHOTOMETRIC_YCBCR seems to simply be a flag to si

Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread Carl Eugen Hoyos
James Almer gmail.com> writes: > +static void unpack_yuv(TiffContext *s, AVFrame *p, > + const uint8_t *src, int lnum) > -static void unpack_yuv(TiffContext *s, AVFrame *p, > - const uint8_t *src, int lnum) If you want you could split the moving of th

Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread Michael Niedermayer
On Tue, Aug 19, 2014 at 01:54:58AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Seems to work great with yuv deflate tiff images created with our tiff encoder > > libavcodec/tiff.c | 71 > +++ > 1 file changed, 35 insertions(

Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread James Almer
On 19/08/14 1:54 AM, James Almer wrote: > Signed-off-by: James Almer > --- > Seems to work great with yuv deflate tiff images created with our tiff encoder > > libavcodec/tiff.c | 71 > +++ > 1 file changed, 35 insertions(+), 36 deletions(-) >

[FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-18 Thread James Almer
Signed-off-by: James Almer --- Seems to work great with yuv deflate tiff images created with our tiff encoder libavcodec/tiff.c | 71 +++ 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c inde