Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Nicolas George
Marvin Scholz (12020-08-09): > I think I already wrote this back when the patch was proposed, > but I tested it and it works fine. > I dont think it can cause any issues in other cases either, > so LGTM. Sorry, I fumbled my mailbox search, I had already applied this. Regards, -- Nicolas Georg

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Marvin Scholz
On 9 Aug 2020, at 13:06, Nicolas George wrote: > Nicolas George (12020-06-02): >> Fix trac ticket #8705. >> >> Signed-off-by: Nicolas George >> --- >> libavformat/tee.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Not tested, I have no icecast server at hand. I will ask the

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Paul B Mahol
On 8/9/20, Nicolas George wrote: > Nicolas George (12020-06-02): >> Fix trac ticket #8705. >> >> Signed-off-by: Nicolas George >> --- >> libavformat/tee.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Not tested, I have no icecast server at hand. I will ask the reporter to >>

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Nicolas George
Nicolas George (12020-06-02): > Fix trac ticket #8705. > > Signed-off-by: Nicolas George > --- > libavformat/tee.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Not tested, I have no icecast server at hand. I will ask the reporter to > test. Ping? Will apply next time I think

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-04 Thread Nicolas George
Marvin Scholz (12020-06-03): > Oh whoops I completely overlooked that and got confused by the command line > on the > ticket itself. > That indeed works fine now with your patch, thanks a lot for the fix, as > this > greatly simplifies sourcing different icecast mountpoints at once for > testing.

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-03 Thread Marvin Scholz
On 3 Jun 2020, at 13:33, Nicolas George wrote: Marvin Scholz (12020-06-03): How would I make that explicit? I checked the command line given on the ticket and I fail to spot the difference, did I get the order wrong or do I miss something else? Quote of the last comment: | I tested your pa

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-03 Thread Nicolas George
Marvin Scholz (12020-06-03): > How would I make that explicit? I checked the command line given on the > ticket and I fail to spot the difference, did I get the order wrong or > do I miss something else? Quote of the last comment: | I tested your patch, it works perfectly. | | (as in, now | "[co

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-03 Thread Marvin Scholz
On 3 Jun 2020, at 11:49, Nicolas George wrote: > Marvin Scholz (12020-06-03): >> Hi, thanks a lot for working on a fix for this. >> >> I've just tried it and it does not seem to work, I still can't pass >> options to the icecast protocol using tee. >> >> Command I tried was: >> >> ffmpeg -re -i in

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-03 Thread Nicolas George
Marvin Scholz (12020-06-03): > Hi, thanks a lot for working on a fix for this. > > I've just tried it and it does not seem to work, I still can't pass > options to the icecast protocol using tee. > > Command I tried was: > > ffmpeg -re -i input.mov -c copy -f tee -password hackme -content_type >

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-02 Thread Marvin Scholz
Hi, thanks a lot for working on a fix for this. I've just tried it and it does not seem to work, I still can't pass options to the icecast protocol using tee. Command I tried was: ffmpeg -re -i input.mov -c copy -f tee -password hackme -content_type audio/ogg -map 0:v -map 0:a "icecast://sour

[FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-02 Thread Nicolas George
Fix trac ticket #8705. Signed-off-by: Nicolas George --- libavformat/tee.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Not tested, I have no icecast server at hand. I will ask the reporter to test. diff --git a/libavformat/tee.c b/libavformat/tee.c index f2b11fcb35..c5c59975e6 1006