Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2016-01-01 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > On Thu, Dec 31, 2015 at 03:59:53PM +, Carl Eugen Hoyos wrote: > > Mats Peterson ffmpeg.org> writes: > > > > > And this patch doesn't affect the current state of > > > the qtrle decoder > > > > Then there is no need for this patch to be > > co

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
if the patch is fixing incorrect code then it should be commited if it doesnt then it should not And to answer that, yes, it fixes incorrect code. If it was OK to apply the previous lavf/qtpalette patch for 1-bit palettized video, it should be OK to apply this bug fix without any superfluo

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 06:24 PM, Michael Niedermayer wrote: if the patch is fixing incorrect code then it should be commited if it doesnt then it should not And to answer that, yes, it fixes incorrect code. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 06:53 PM, Mats Peterson wrote: On 12/31/2015 06:24 PM, Michael Niedermayer wrote: do you prefer that the decoder patch is pushed first? or do i misunderstand? but i can surely push that first if thats preferred It's a small one-liner, as you can see, that ignores the greyscale

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 06:24 PM, Michael Niedermayer wrote: do you prefer that the decoder patch is pushed first? or do i misunderstand? but i can surely push that first if thats preferred It's a small one-liner, as you can see, that ignores the greyscale bit for 1-bit video. This should be done rega

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Michael Niedermayer
On Thu, Dec 31, 2015 at 03:59:53PM +, Carl Eugen Hoyos wrote: > Mats Peterson ffmpeg.org> writes: > > > And this patch doesn't affect the current state of > > the qtrle decoder > > Then there is no need for this patch to be > committed yet. if the patch is fixing incorrect code then it sh

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 05:04 PM, Mats Peterson wrote: > Alright, Michael, do whatever you want, but it's awkward to have this patch lying around for no reason, when it's such a small change. Mats Let me repeat a snippet from the QuickTime File Format Specification: "Depth: A 16-bit integer that indic

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 05:00 PM, Mats Peterson wrote: I would gladly get rid of this one-liner in the meantime. It's "my" file at that. Mats Alright, Michael, do whatever you want, but it's awkward to have this patch lying around for no reason, when it's such a small change. Mats

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 04:59 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: And this patch doesn't affect the current state of the qtrle decoder Then there is no need for this patch to be committed yet. Carl Eugen ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > And this patch doesn't affect the current state of > the qtrle decoder Then there is no need for this patch to be committed yet. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/31/2015 04:54 PM, Michael Niedermayer wrote: On Thu, Dec 31, 2015 at 04:47:20PM +0100, Mats Peterson wrote: On 12/30/2015 07:56 PM, Mats Peterson wrote: On 12/30/2015 07:52 PM, Mats Peterson wrote: Michael, can you apply this one in the meantime, just to get rid of it, and if it seems se

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Michael Niedermayer
On Thu, Dec 31, 2015 at 04:47:20PM +0100, Mats Peterson wrote: > On 12/30/2015 07:56 PM, Mats Peterson wrote: > >On 12/30/2015 07:52 PM, Mats Peterson wrote: > >>Michael, can you apply this one in the meantime, just to get rid of it, > >>and if it seems sensible, until someone discovers how to solv

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-31 Thread Mats Peterson
On 12/30/2015 07:56 PM, Mats Peterson wrote: On 12/30/2015 07:52 PM, Mats Peterson wrote: Michael, can you apply this one in the meantime, just to get rid of it, and if it seems sensible, until someone discovers how to solve the 1-bit palettized qtrle issue? In the decoder, that is. Mats

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-30 Thread Mats Peterson
On 12/30/2015 07:52 PM, Mats Peterson wrote: Michael, can you apply this one in the meantime, just to get rid of it, and if it seems sensible, until someone discovers how to solve the 1-bit palettized qtrle issue? Mats ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-30 Thread Mats Peterson
Michael, can you apply this one in the meantime, just to get rid of it, and if it seems sensible, until someone discovers how to solve the 1-bit palettized qtrle issue? Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 60798a04ef1204dadf5395cbf7205ea3957fafbb Mon Sep 17 00:00:00 200

[FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2015-12-29 Thread Mats Peterson
The QuickTime File Format Specification states the following: "Depth: A 16-bit integer that indicates the pixel depth of the compressed image. Values of 1, 2, 4, 8 ,16, 24, and 32 indicate the depth of color images. The value 32 should be used only if the image contains an alpha channel. Values o