SGTM. Thanks James.
On Tue, Mar 6, 2018 at 6:23 AM, James Almer wrote:
> On 3/5/2018 10:04 PM, Matthew Wolenetz wrote:
> > Perhaps true, but there are a ton of paths to ff_alloc_extradata that are
> > not included in Chromium. Such a wider, general, fix seems more
> appropriate
> > to land upstr
On 3/5/2018 10:04 PM, Matthew Wolenetz wrote:
> Perhaps true, but there are a ton of paths to ff_alloc_extradata that are
> not included in Chromium. Such a wider, general, fix seems more appropriate
> to land upstream first with more testing.
The function allocates a buffer and overwrites the poi
Perhaps true, but there are a ton of paths to ff_alloc_extradata that are
not included in Chromium. Such a wider, general, fix seems more appropriate
to land upstream first with more testing.
For now, this is a particular known case that's occurring in Chromium that
needs fixing.
On Mon, Mar 5, 20
On 3/5/2018 6:54 PM, Matthew Wolenetz wrote:
>
> 0001-lavf-oggparseflac-Free-flac-extradata-before-realloc.patch
>
>
> From 5d28b92d9d164b104e9a47b8183cd7ddedfde366 Mon Sep 17 00:00:00 2001
> From: Matt Wolenetz
> Date: Mon, 5 Mar 2018 12:36:28 -0800
> Subject: [PATCH] lavf/oggparseflac: Free f
From 5d28b92d9d164b104e9a47b8183cd7ddedfde366 Mon Sep 17 00:00:00 2001
From: Matt Wolenetz
Date: Mon, 5 Mar 2018 12:36:28 -0800
Subject: [PATCH] lavf/oggparseflac: Free flac extradata before reallocating.
Otherwise ff_alloc_extradata() just leaks any existing allocated
memory.
BUG=789835
Chang
