Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-06 Thread wm4
On Fri, 3 Feb 2017 14:42:44 -0800 Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is increased by a > longstanding b

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-04 Thread wm4
On Fri, 3 Feb 2017 14:42:44 -0800 Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is increased by a > longstanding b

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread Vignesh Venkatasubramanian
On Fri, Feb 3, 2017 at 2:42 PM, Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is increased by a > longstanding bug in

[FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread Chris Cunningham
Blocks are marked as key frames whenever the "reference" field is zero. This breaks for non-keyframe Blocks with a reference timestamp of zero. The likelihood of reference timestamp being zero is increased by a longstanding bug in muxing that encodes reference timestamp as the absolute time of the

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread wm4
On Fri, 3 Feb 2017 10:04:34 -0800 Vignesh Venkatasubramanian wrote: > On Thu, Feb 2, 2017 at 10:16 PM, wm4 wrote: > > On Thu, 2 Feb 2017 10:47:52 -0800 > > Vignesh Venkatasubramanian wrote: > > > >> On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: > >> > > >> > On Tue, 31 Jan 2017 12:02:01 -08

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread Vignesh Venkatasubramanian
On Thu, Feb 2, 2017 at 10:16 PM, wm4 wrote: > On Thu, 2 Feb 2017 10:47:52 -0800 > Vignesh Venkatasubramanian wrote: > >> On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: >> > >> > On Tue, 31 Jan 2017 12:02:01 -0800 >> > Chris Cunningham wrote: >> > >> > > Thanks for taking a look. >> > > >> > > Def

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-02 Thread wm4
On Thu, 2 Feb 2017 10:47:52 -0800 Vignesh Venkatasubramanian wrote: > On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: > > > > On Tue, 31 Jan 2017 12:02:01 -0800 > > Chris Cunningham wrote: > > > > > Thanks for taking a look. > > > > > > Definitely missing a "break;" - will fix in subsequent patc

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-02 Thread Vignesh Venkatasubramanian
On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: > > On Tue, 31 Jan 2017 12:02:01 -0800 > Chris Cunningham wrote: > > > Thanks for taking a look. > > > > Definitely missing a "break;" - will fix in subsequent patch. > > > > Agree timestamps should be relative (didn't realize this). Vignesh points > >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-01 Thread Chris Cunningham
On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: > On Tue, 31 Jan 2017 12:02:01 -0800 > Chris Cunningham wrote: > > > Thanks for taking a look. > > > > Definitely missing a "break;" - will fix in subsequent patch. > > > > Agree timestamps should be relative (didn't realize this). Vignesh points > >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-31 Thread Chrome Cunningham
On Tuesday, January 31, 2017, Chris Cunningham wrote: > > On Tue, Jan 31, 2017 at 1:07 AM, wm4 > wrote: > >> On Tue, 31 Jan 2017 09:57:24 +0100 >> wm4 > > wrote: >> >> > On Mon, 30 Jan 2017 17:05:49 -0800 >> > Chris Cunningham > > wrote: >> > >> > > Blocks are marked as key frames whenever the "

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-31 Thread wm4
On Tue, 31 Jan 2017 12:02:01 -0800 Chris Cunningham wrote: > Thanks for taking a look. > > Definitely missing a "break;" - will fix in subsequent patch. > > Agree timestamps should be relative (didn't realize this). Vignesh points > out that "0" in the test file is due to a bug in ffmpeg (and p

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-31 Thread Chris Cunningham
On Tue, Jan 31, 2017 at 1:07 AM, wm4 wrote: > On Tue, 31 Jan 2017 09:57:24 +0100 > wm4 wrote: > > > On Mon, 30 Jan 2017 17:05:49 -0800 > > Chris Cunningham wrote: > > > > > Blocks are marked as key frames whenever the "reference" field is > > > zero. This is incorrect for non-keyframe Blocks th

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-31 Thread wm4
On Tue, 31 Jan 2017 09:57:24 +0100 wm4 wrote: > On Mon, 30 Jan 2017 17:05:49 -0800 > Chris Cunningham wrote: > > > Blocks are marked as key frames whenever the "reference" field is > > zero. This is incorrect for non-keyframe Blocks that take a refernce > > on a keyframe at time zero. > > > >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-31 Thread wm4
On Mon, 30 Jan 2017 17:05:49 -0800 Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This is incorrect for non-keyframe Blocks that take a refernce > on a keyframe at time zero. > > Now using -1 to denote "no reference". > > Reported to chromium

[FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-01-30 Thread Chris Cunningham
Blocks are marked as key frames whenever the "reference" field is zero. This is incorrect for non-keyframe Blocks that take a refernce on a keyframe at time zero. Now using -1 to denote "no reference". Reported to chromium at http://crbug.com/497889 (contains sample) --- libavformat/matroskadec.