Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-26 Thread ooe

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-26 Thread Reimar Döffinger
On 25.08.2014, at 18:15, Vignesh Venkatasubramanian wrote: > avio_seek(matroska->ctx->pb, before_pos, SEEK_SET); > +if (cues_start == -1 || cues_end == -1) return -1; Shouldn't this use something more descriptive than -1? ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 09:15:13AM -0700, Vignesh Venkatasubramanian wrote: > Ensure that cues_start and cues_end are always initialized and > the webm_dash_manifest_cues function returns appropriate error if > they are not computed correctly. > > This fixes coverity defect CID1231991. > > Signed