Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-29 Thread James Almer
On 29/10/14 11:20 AM, Giorgio Vazzana wrote: > 2014-10-21 12:26 GMT+02:00 Stefano Sabatini : >> On date Tuesday 2014-10-21 03:56:06 -0300, James Almer encoded: >>> No need to keep the old symbols around until a major bump since lavd >>> functions >>> with the avpriv_ prefix were never exposed. >>>

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-29 Thread Michael Niedermayer
On Wed, Oct 29, 2014 at 03:20:02PM +0100, Giorgio Vazzana wrote: > 2014-10-21 12:26 GMT+02:00 Stefano Sabatini : > > On date Tuesday 2014-10-21 03:56:06 -0300, James Almer encoded: > >> No need to keep the old symbols around until a major bump since lavd > >> functions > >> with the avpriv_ prefix

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-29 Thread Giorgio Vazzana
2014-10-21 12:26 GMT+02:00 Stefano Sabatini : > On date Tuesday 2014-10-21 03:56:06 -0300, James Almer encoded: >> No need to keep the old symbols around until a major bump since lavd >> functions >> with the avpriv_ prefix were never exposed. >> >> Signed-off-by: James Almer > > LGTM. Ping. Any

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-21 Thread Stefano Sabatini
On date Tuesday 2014-10-21 03:56:06 -0300, James Almer encoded: > No need to keep the old symbols around until a major bump since lavd > functions > with the avpriv_ prefix were never exposed. > > Signed-off-by: James Almer LGTM. [...] -- FFmpeg = Fast and Faithless Multimedia Political Eage

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-21 Thread Derek Buitenhuis
On 10/21/2014 7:56 AM, James Almer wrote: > No need to keep the old symbols around until a major bump since lavd > functions > with the avpriv_ prefix were never exposed. lol. > Signed-off-by: James Almer > --- > "avpriv_*;" can be added to libavdevice.v after this patch, but personally > I'd

[FFmpeg-devel] [PATCH] lavd/v4l2: don't use avpriv_ prefix for internal functions

2014-10-20 Thread James Almer
No need to keep the old symbols around until a major bump since lavd functions with the avpriv_ prefix were never exposed. Signed-off-by: James Almer --- "avpriv_*;" can be added to libavdevice.v after this patch, but personally I'd say to wait until it's needed rather than adding it right now