Re: [FFmpeg-devel] [PATCH] lavc/x86/videodsp: Fix clobbered FPU state on x86-32

2024-11-12 Thread James Almer
On 11/12/2024 9:37 AM, Ronald S. Bultje wrote: Hi, On Mon, Nov 11, 2024 at 4:03 AM Frank Plowman wrote: I thought the same before submitting this patch, and tried only adding the line conditionally based on the mmsize, but found neither wrapping it in an a) mmsize == 8, nor b) mmsize != 8 blo

Re: [FFmpeg-devel] [PATCH] lavc/x86/videodsp: Fix clobbered FPU state on x86-32

2024-11-12 Thread Ronald S. Bultje
Hi, On Mon, Nov 11, 2024 at 4:03 AM Frank Plowman wrote: > I thought the same before submitting this patch, and tried only adding > the line conditionally based on the mmsize, but found neither wrapping > it in an a) mmsize == 8, nor b) mmsize != 8 block alone worked. > Can we just get rid of t

Re: [FFmpeg-devel] [PATCH] lavc/x86/videodsp: Fix clobbered FPU state on x86-32

2024-11-11 Thread Frank Plowman
On 10/11/2024 23:57, James Almer wrote: > On 11/10/2024 3:38 PM, Frank Plowman wrote: >> These assembly optimisations can use MMX.  They failed to reset the >> floating-point state when they are done, hence subsequent floating-point >> operations return nonsense values. >> >> This fixes the FATE fa

Re: [FFmpeg-devel] [PATCH] lavc/x86/videodsp: Fix clobbered FPU state on x86-32

2024-11-10 Thread James Almer
On 11/10/2024 3:38 PM, Frank Plowman wrote: These assembly optimisations can use MMX. They failed to reset the floating-point state when they are done, hence subsequent floating-point operations return nonsense values. This fixes the FATE failure for vvc-output-ref on x86-32, e.g. https://fate.

[FFmpeg-devel] [PATCH] lavc/x86/videodsp: Fix clobbered FPU state on x86-32

2024-11-10 Thread Frank Plowman
These assembly optimisations can use MMX. They failed to reset the floating-point state when they are done, hence subsequent floating-point operations return nonsense values. This fixes the FATE failure for vvc-output-ref on x86-32, e.g. https://fate.ffmpeg.org/report.cgi?slot=x86_32-uubuntu-ming