Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix race condition for MVs cropped to subpic

2024-12-30 Thread Nuo Mi
On Sun, Dec 29, 2024 at 6:24 PM Frank Plowman wrote: > Hi, > > Thank you for your review. > > It seems your mail did not reach the ML for whatever reason. I have > ensured your comments are all left verbatim below so that others may > read them. > Thank you. > > On 29/12/2024 03:44, Nuo Mi wrot

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix race condition for MVs cropped to subpic

2024-12-29 Thread Nuo Mi
Hi Frank, Thank you for the patch. On Sun, Dec 22, 2024 at 9:40 PM Frank Plowman wrote: > When the current subpicture has sps_subpic_treated_as_pic_flag equal to > 1, motion vectors are cropped such that they cannot point to other > subpictures. This was accounted for in the prediction logic, b

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix race condition for MVs cropped to subpic

2024-12-29 Thread Frank Plowman
Hi, Thank you for your review. It seems your mail did not reach the ML for whatever reason. I have ensured your comments are all left verbatim below so that others may read them. On 29/12/2024 03:44, Nuo Mi wrote: > Hi Frank, > Thank you for the patch. > > On Sun, Dec 22, 2024 at 9:40 PM Frank

[FFmpeg-devel] [PATCH] lavc/vvc: Fix race condition for MVs cropped to subpic

2024-12-22 Thread Frank Plowman
When the current subpicture has sps_subpic_treated_as_pic_flag equal to 1, motion vectors are cropped such that they cannot point to other subpictures. This was accounted for in the prediction logic, but not in pred_get_y, which is used by the scheduling logic to determine which parts of the refer