Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Derek Buitenhuis
On 11/9/2017 1:23 PM, Rostislav Pehlivanov wrote: >> For now, and only because you looked at the code. But the current code >> does not follow the documentation, so it is really a fix. >> >> > That type of fix is called a correction. It's a fix. Relying on internal implementation knowledge is a bu

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 13:15, Nicolas George wrote: > Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > > Its not really a fix since bprint can't return non-ENOMEM. All were > copied > > For now, and only because you looked at the code. But the current code > does not follow the d

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > Its not really a fix since bprint can't return non-ENOMEM. All were copied For now, and only because you looked at the code. But the current code does not follow the documentation, so it is really a fix. > from one place in the co

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 08:49, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavcodec/pngdec.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 20707f0ae5..1d72f9542a 100644 > --- a/liba

[FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Nicolas George
Signed-off-by: Nicolas George --- libavcodec/pngdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 20707f0ae5..1d72f9542a 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -524,9 +524,9 @@ static