On Thu, Jan 30, 2020 at 07:40:53PM +0100, Michael Kuron wrote:
> Is there anything else you need me to change before this can be
> merged? If not, I am happy to split it into two patches if necessary.
spliting the patch would certainly be a good thing if noone has any
objections to the patch itsel
Is there anything else you need me to change before this can be
merged? If not, I am happy to split it into two patches if necessary.
On Sat, Jan 25, 2020 at 3:33 PM Michael Kuron wrote:
>
> Previously, the default palette would always be used.
> Now, we can accept a custom palette, just like dvd
Previously, the default palette would always be used.
Now, we can accept a custom palette, just like dvdsubdec does.
Signed-off-by: Michael Kuron
---
doc/decoders.texi | 2 +-
doc/encoders.texi | 8
libavcodec/Makefile| 2 ++
libavcodec/dvdsub.c| 33
Michael Kuron (12020-01-25):
> Previously, the default palette would always be used.
> Now, we can accept a custom palette, just like dvdsubdec does.
>
> Signed-off-by: Michael Kuron
> ---
> doc/decoders.texi | 2 +-
> doc/encoders.texi | 8
> libavcodec/Makefile| 1 +
>
Previously, the default palette would always be used.
Now, we can accept a custom palette, just like dvdsubdec does.
Signed-off-by: Michael Kuron
---
doc/decoders.texi | 2 +-
doc/encoders.texi | 8
libavcodec/Makefile| 1 +
libavcodec/dvdsub.c| 35 +
Michael Kuron (12020-01-25):
> In fact, this entire patch is
> basically copy+paste from there.
Then please fix the patch so that the same code is used, not a copy of
it. Otherwise, enhancements or fixes would have to be duplicated too.
Regards,
--
Nic
On Sat, Jan 25, 2020 at 01:24 AM Carl Eugen Hoyos wrote:
>> static const AVOption options[] = {
>> +{"palette", "set the global palette", OFFSET(palette_str),
>> AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, SE },
>
> What happens if invalid values are passed as palette?
The string is parsed un
Am Fr., 24. Jan. 2020 um 23:49 Uhr schrieb Michael Kuron
:
>
> Previously, the default palette would always be used.
> Now, we can accept a custom palette, just like dvdsubdec does.
>
> Signed-off-by: Michael Kuron
> ---
> doc/encoders.texi | 8
> libavcodec/dvdsubenc.c | 19 ++
Previously, the default palette would always be used.
Now, we can accept a custom palette, just like dvdsubdec does.
Signed-off-by: Michael Kuron
---
doc/encoders.texi | 8
libavcodec/dvdsubenc.c | 19 ++-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --gi
On Fri, Jan 24, 2020 at 7:26 PM Michael Kuron
wrote:
> Previously, the default palette would always be used.
> Now, we can accept a custom palette, just like dvdsubdec does.
>
> Signed-off-by: Michael Kuron
> ---
> doc/encoders.texi | 9 +
> libavcodec/dvdsubenc.c | 19 +++
Previously, the default palette would always be used.
Now, we can accept a custom palette, just like dvdsubdec does.
Signed-off-by: Michael Kuron
---
doc/encoders.texi | 9 +
libavcodec/dvdsubenc.c | 19 ++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --g
0001-lavc-dvdsubenc-accept-palette-from-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpe
12 matches
Mail list logo