Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
Now realizing that there's not really a way to just query all modifiers, you'd actually need to query all formats for their modifiers... Options as I see it are: 1. in init(), create a table of all (vk_format, modifier) pairs and the `VkDrmFormatModifierPropertiesEXT` information about the pair fo

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
> > If we're OK with a practical "we don't support drivers with more than > > X modifiers because we doubt it'll ever exist" then that's a valid > > answer as well. > If that's your concern, just fetch all info for all modifiers in the > init function. Works for me. I'm new to ffmpeg devel, I assu

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Lynne
On 03/05/2025 17:01, Russell Greene wrote: vkGetPhysicalDeviceToolPropertiesEXT(dev, nb, array) If pToolProperties is NULL, then the number of tools currently active on physicalDevice is returned in pToolCount. Otherwise, pToolCount must point to a variable set by the application to the number of

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
> vkGetPhysicalDeviceToolPropertiesEXT(dev, nb, array) > If pToolProperties is NULL, then the number of tools currently active on > physicalDevice is returned in pToolCount. Otherwise, pToolCount must > point to a variable set by the application to the number of elements in > the pToolProperties ar

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Lynne
On 03/05/2025 04:39, Russell Greene wrote: Is this documented anywhere? Should I maybe have a fixed sized stack buffer and fallback to an allocation if it's just a rule of thumb that it'll be less than some known small number. I just somehow doubt this is in the vulkan spec or any sort of guarant

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-02 Thread Russell Greene
Is this documented anywhere? Should I maybe have a fixed sized stack buffer and fallback to an allocation if it's just a rule of thumb that it'll be less than some known small number. I just somehow doubt this is in the vulkan spec or any sort of guaranteed On Thu, May 1, 2025 at 6:10 PM Lynne

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-01 Thread Lynne
On 01/05/2025 07:05, Russell Greene wrote: From: Russell Greene Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the stru

[FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-04-30 Thread Russell Greene
From: Russell Greene Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the structs appropriately in this situation. The en

[FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-04-29 Thread Russell Greene
Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the structs appropriately in this situation. The encoded stream is still ba