Re: [FFmpeg-devel] [PATCH] hevc: fix size condition in ptl parsing

2016-05-06 Thread Michael Niedermayer
On Fri, May 06, 2016 at 07:15:06PM +0200, Hendrik Leppkes wrote: > When only one sublayer is present, no information is coded. Only when at > least two > are present, all 8 sublayers are written. > --- > libavcodec/hevc_ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...

Re: [FFmpeg-devel] [PATCH] hevc: fix size condition in ptl parsing

2016-05-06 Thread Hendrik Leppkes
On Fri, May 6, 2016 at 7:49 PM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> -get_bits_left(gb) < 8 + 8*2) { >> +get_bits_left(gb) < 8 + (8*2 * (max_num_sub_layers - 1 > 0))) { > > Isnt't "max_num_sub_layers > 1" more readable? > Perhaps, but this syntax is used in t

Re: [FFmpeg-devel] [PATCH] hevc: fix size condition in ptl parsing

2016-05-06 Thread Carl Eugen Hoyos
Hendrik Leppkes gmail.com> writes: > -get_bits_left(gb) < 8 + 8*2) { > +get_bits_left(gb) < 8 + (8*2 * (max_num_sub_layers - 1 > 0))) { Isnt't "max_num_sub_layers > 1" more readable? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

[FFmpeg-devel] [PATCH] hevc: fix size condition in ptl parsing

2016-05-06 Thread Hendrik Leppkes
When only one sublayer is present, no information is coded. Only when at least two are present, all 8 sublayers are written. --- libavcodec/hevc_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index ce3f3df..83f2ec2 100644 --- a