Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 04:17:56PM -0500, Will Kelleher wrote: > > On 04/08, Michael Niedermayer wrote: > > > > > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > > > parsed, and then freed after it gets written to the output frame's

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 04:17:56PM -0500, Will Kelleher wrote: > On 04/08, Michael Niedermayer wrote: > > > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > > parsed, and then freed after it gets written to the output frame's > > > side data in hevc_frame_start. > > > > a

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > parsed, and then freed after it gets written to the output frame's > > side data in hevc_frame_start. > > and if an error happens between it leaks ? > If an error occurred after sei

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 02:35:09PM -0500, Will Kelleher wrote: > On 04/08, Michael Niedermayer wrote: > > On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > > > Signed-off-by: Will Kelleher > > > --- > > > libavcodec/hevc_parser.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > >

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > > Signed-off-by: Will Kelleher > > --- > > libavcodec/hevc_parser.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c > > in

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Michael Niedermayer
On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > Signed-off-by: Will Kelleher > --- > libavcodec/hevc_parser.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c > index 4625e61..5558afc 100644 > --- a/libavcodec/hevc_p

[FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 4625e61..5558afc 100644 --- a/libavcodec/hevc_parser.c +++ b/libavcodec/hevc_parser.c @@ -202,6 +202,9 @@ static inline int pa