Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 12.06.2015 20:40, Michael Niedermayer wrote: > On Fri, Jun 12, 2015 at 06:19:47PM +0200, Andreas Cadhalpun wrote: >> On 10.06.2015 21:50, Michael Niedermayer wrote: >>> On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: Could these be fixed to use a new H264Context field ins

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Michael Niedermayer
On Fri, Jun 12, 2015 at 06:19:47PM +0200, Andreas Cadhalpun wrote: > On 10.06.2015 21:50, Michael Niedermayer wrote: > > On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: > >> On 10.06.2015 12:01, Michael Niedermayer wrote: > also avctx->pix_fmt would then still potentially no

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 10.06.2015 21:50, Michael Niedermayer wrote: > On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: >> On 10.06.2015 12:01, Michael Niedermayer wrote: also avctx->pix_fmt would then still potentially not match the last output frame, also pix_fmt has the same problem as ab

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-10 Thread Michael Niedermayer
On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: > On 10.06.2015 12:01, Michael Niedermayer wrote: > > On Wed, Jun 10, 2015 at 11:43:16AM +0200, Michael Niedermayer wrote: > >> On Tue, Jun 09, 2015 at 11:53:03PM +0200, Andreas Cadhalpun wrote: > >>> Inconsistencies between the dim

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-10 Thread Andreas Cadhalpun
On 10.06.2015 12:01, Michael Niedermayer wrote: > On Wed, Jun 10, 2015 at 11:43:16AM +0200, Michael Niedermayer wrote: >> On Tue, Jun 09, 2015 at 11:53:03PM +0200, Andreas Cadhalpun wrote: >>> Inconsistencies between the dimensions of avctx and the frame can >>> confuse API users. For example this

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-10 Thread Michael Niedermayer
On Wed, Jun 10, 2015 at 11:43:16AM +0200, Michael Niedermayer wrote: > On Tue, Jun 09, 2015 at 11:53:03PM +0200, Andreas Cadhalpun wrote: > > Inconsistencies between the dimensions of avctx and the frame can > > confuse API users. For example this can crash the demuxing_decoding > > example. > > >

Re: [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-10 Thread Michael Niedermayer
On Tue, Jun 09, 2015 at 11:53:03PM +0200, Andreas Cadhalpun wrote: > Inconsistencies between the dimensions of avctx and the frame can > confuse API users. For example this can crash the demuxing_decoding > example. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/h264.c | 4 > 1 fil

[FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-09 Thread Andreas Cadhalpun
Inconsistencies between the dimensions of avctx and the frame can confuse API users. For example this can crash the demuxing_decoding example. Signed-off-by: Andreas Cadhalpun --- libavcodec/h264.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c inde