2017-11-28 1:12 GMT+01:00 Bjorn Roche :
> On Mon, Nov 27, 2017 at 5:35 PM, Carl Eugen Hoyos
> wrote:
>
>> 2017-11-27 19:30 GMT+01:00 Bjorn Roche :
>> >
>>
>> > The only way I can see is to move some functionality between the mixer
>> and
>> > the encoder. It's not a clear line between the codec an
On Mon, Nov 27, 2017 at 5:35 PM, Carl Eugen Hoyos
wrote:
> 2017-11-27 19:30 GMT+01:00 Bjorn Roche :
> >
>
> > The only way I can see is to move some functionality between the mixer
> and
> > the encoder. It's not a clear line between the codec and the container in
> > GIF, so I wouldn't object to
2017-11-27 19:30 GMT+01:00 Bjorn Roche :
>
> On Fri, Nov 3, 2017 at 8:11 PM, Carl Eugen Hoyos wrote:
>
>> 2017-10-24 18:40 GMT+02:00 Bjorn Roche :
>>
>> > - I don’t know if/how to update the FATE tests.
>>
>> A quick way (that needs some double-checking) is:
>> $ make GEN=1 SAMPLES=fate-suite fate
Thanks Moritz and Carl for your help with fate. This email was stuck in my
drafts :(
Comments below:
On Fri, Nov 3, 2017 at 8:11 PM, Carl Eugen Hoyos wrote:
> 2017-10-24 18:40 GMT+02:00 Bjorn Roche :
>
> > - I don’t know if/how to update the FATE tests.
>
> A quick way (that needs some double-c
2017-10-24 18:40 GMT+02:00 Bjorn Roche :
> - I don’t know if/how to update the FATE tests.
A quick way (that needs some double-checking) is:
$ make GEN=1 SAMPLES=fate-suite fate
(This overwrites all values with the new output.)
Is the new side-data unavoidable?
(Would the only alternative be to
On Thu, Nov 02, 2017 at 11:45:20 -0400, Bjorn Roche wrote:
> > - I don’t know if/how to update the FATE tests.
>
> Can anyone comment on this? Do I update the tests in the same patch or
> separate that?
Your patch is not allowed to break fate. If the fate results are
correct references, then fate
> - I don’t know if/how to update the FATE tests.
Can anyone comment on this? Do I update the tests in the same patch or
separate that?
--
Bjorn Roche
Sr. Video Pipeline Engineer
bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.or
On Wed, Oct 25, 2017 at 09:51:39AM -0400, Bjorn Roche wrote:
> On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer > wrote:
>
> > On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote:
> > > Support for transparencies in animated gifs requires modifying both
> > > libavcodec/gif.c and liba
On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer wrote:
> On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote:
> > Support for transparencies in animated gifs requires modifying both
> > libavcodec/gif.c and libavformat/gif.c because both the graphics
> > control extension (handled by
On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote:
> Support for transparencies in animated gifs requires modifying both
> libavcodec/gif.c and libavformat/gif.c because both the graphics
> control extension (handled by libavformat/gif.c) and the raw frame data
> (handled by libavcodec/gi
On Tue, Oct 24, 2017 at 4:24 PM, Carl Eugen Hoyos
wrote:
> 2017-10-24 18:40 GMT+02:00 Bjorn Roche :
>
> > This patch assumes paletteuse has already been patched to support
> > transparency. (e.g. lavfi/paletteuse: fix to support transparency)
>
> Which should - imo - be unrelated to this patch an
2017-10-24 18:40 GMT+02:00 Bjorn Roche :
[...]
The patch adds two warnings here on compilation of gif.c,
they should be fixed at some point:
libavcodec/gif.c:164:5: warning: ISO C90 forbids mixed declarations
and code [-Wdeclaration-after-statement]
uint8_t *frame_disposal = av_packet_new_s
2017-10-24 18:40 GMT+02:00 Bjorn Roche :
> This patch assumes paletteuse has already been patched to support
> transparency. (e.g. lavfi/paletteuse: fix to support transparency)
Which should - imo - be unrelated to this patch and indeed, transcoding
a pal8 apng (produced with your paletteuse patc
Support for transparencies in animated gifs requires modifying both
libavcodec/gif.c and libavformat/gif.c because both the graphics
control extension (handled by libavformat/gif.c) and the raw frame data
(handled by libavcodec/gif.c) must be changed. This is because
transparencies in GIF can be us
14 matches
Mail list logo
