Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
I get it now. Disregard patch. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Andreas Rheinhardt
Marth64: >> The code block changes str and str is later accessed (via splitconf). > Sorry, for the lack of awareness, but I am confused how. > strstr() shouldn't modify the string right? > The only change I see is in the unused remove_tilde[] > No, but strstr() returns a pointer pointing into the

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
> The code block changes str and str is later accessed (via splitconf). Sorry, for the lack of awareness, but I am confused how. strstr() shouldn't modify the string right? The only change I see is in the unused remove_tilde[] Thank you, for taking a look and explaining. __

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Andreas Rheinhardt
Marth64: > I found this code block when looking at this warning thrown in my > compiler (gcc 11.4.0 x86_64-linux-gnu): > > ``` > In function ‘print_buildconf’, > inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5: > fftools/opt_common.c:226:49: warning: writing 1 byte into a region of

[FFmpeg-devel] [PATCH] fftools/opt_common: remove dead code in print_buildconf()

2024-03-12 Thread Marth64
I found this code block when looking at this warning thrown in my compiler (gcc 11.4.0 x86_64-linux-gnu): ``` In function ‘print_buildconf’, inlined from ‘show_buildconf’ at fftools/opt_common.c:260:5: fftools/opt_common.c:226:49: warning: writing 1 byte into a region of size 0 [-Wstringop-ov