Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check

2024-08-14 Thread Anton Khirnov
Quoting Marvin Scholz (2024-08-13 20:06:42) > When ret is checked here, it was never assigned anything, making this > check useless, as highlighted by Coverity. > > It seems to be a copy paste mistake given that opt_match_per_stream_str > does not return an error code that could be checked and the

[FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check

2024-08-13 Thread Marvin Scholz
When ret is checked here, it was never assigned anything, making this check useless, as highlighted by Coverity. It seems to be a copy paste mistake given that opt_match_per_stream_str does not return an error code that could be checked and the previous value assigned to ret is already checked abo