Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-30 Thread James Almer
On 4/30/2018 12:53 PM, Michael Niedermayer wrote: > On Sun, Apr 29, 2018 at 08:09:40PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> fftools/ffmpeg.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) > > LGTM > > thx Pushed. ___

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-30 Thread Michael Niedermayer
On Sun, Apr 29, 2018 at 08:09:40PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffmpeg.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-29 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d3054092ba..4be6e46d9b 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -4727,8 +4727,7 @@ static int transcode(void)

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-29 Thread Hendrik Leppkes
On Sun, Apr 29, 2018 at 4:00 PM, James Almer wrote: > On 4/29/2018 8:08 AM, Derek Buitenhuis wrote: >> On 4/29/2018 3:21 AM, James Almer wrote: >>> +BenchmarkTimeStamps time_stamps = { .real_usec = av_gettime_relative() >>> }; >> >> Does this build on supported versions of MSVC? > > I don't k

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-29 Thread wm4
On Sat, 28 Apr 2018 23:21:27 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffmpeg.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index d3054092ba..9b3e9d121e 100644 > --- a/fftools/ffmpeg.c > +

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-29 Thread James Almer
On 4/29/2018 8:08 AM, Derek Buitenhuis wrote: > On 4/29/2018 3:21 AM, James Almer wrote: >> +BenchmarkTimeStamps time_stamps = { .real_usec = av_gettime_relative() >> }; > > Does this build on supported versions of MSVC? I don't know, i don't have MSVC to test. And afaik we support only 2013

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-29 Thread Derek Buitenhuis
On 4/29/2018 3:21 AM, James Almer wrote: > +BenchmarkTimeStamps time_stamps = { .real_usec = av_gettime_relative() }; Does this build on supported versions of MSVC? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

2018-04-28 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d3054092ba..9b3e9d121e 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -4727,8 +4727,7 @@ static int transcode(void)