Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-28 Thread Gyan Doshi
On 29-06-2018 01:58 AM, Morten With wrote: av_log(NULL, AV_LOG_WARNING, "-sseof value seeks to before start of file %s; ignored\n", filename); should be an AV_LOG_ERROR and an exit_program(1) afterwards. The warning is very high up and on a file with lots of info you will probably miss it and

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-28 Thread Morten With
Hi, currently on the -toeof patch, and while working on it I noticed that maybe >av_log(NULL, AV_LOG_WARNING, "-sseof value seeks to before start of file %s; ignored\n", filename); should be an AV_LOG_ERROR and an exit_program(1) afterwards. The warning is very high up and on a file with lots of

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-25 Thread Gyan Doshi
On 25-06-2018 10:07 AM, Gyan Doshi wrote: Revised. Will push soon. Thanks, Gyan Pushed in a0ac49e38ee1d1011c394d7be67d0f08b2281526 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-24 Thread Gyan Doshi
On 25-06-2018 06:39 AM, Michael Niedermayer wrote: arguments types are wrong } + timestamp = (o->start_time == AV_NOPTS_VALUE) ? 0 : o->start_time; unrelated, this should not be in this patch Revised. Will push soon. Thanks, Gyan From ca9d51bca4cb303897bf32ff3900fa36f3cf707

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-24 Thread Michael Niedermayer
On Sat, Jun 23, 2018 at 10:17:45AM +0530, Gyan Doshi wrote: > > Added another check and corrected an oversight in a log message. > ffmpeg_opt.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > 663aeb89592e5538ac36e738815b105ab0708d6f > v2-0001-fftools-ffmpeg-check-s

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-24 Thread Gyan Doshi
Will push in a day if no comments. (fixed the missing loglevel locally) Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-22 Thread Gyan Doshi
Added another check and corrected an oversight in a log message. From f013a502c438ef9940fc131cad9bf870853adb5f Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 22 Jun 2018 22:02:16 +0530 Subject: [PATCH v2] fftools/ffmpeg: check sseof value and clash with ss Prioritize -ss --- fftools/ffmp

[FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-22 Thread Gyan Doshi
From 326e15dcfc3ddb1d9b8fd06a5806807917f56669 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 22 Jun 2018 22:02:16 +0530 Subject: [PATCH] fftools/ffmpeg: check sseof value and clash with ss Prioritize -ss --- fftools/ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletio

[FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-22 Thread Gyan Doshi
From 91d98675cc85bd78e46971f9e5d3708245345654 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Thu, 7 Jun 2018 23:15:35 +0530 Subject: [PATCH] ffmpeg: sseof is marked as an input-only option --- doc/ffmpeg.texi | 2 +- fftools/ffmpeg_opt.c | 2 +- 2 files changed, 2 insertions(+), 2 deleti

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: check sseof value and clash with ss

2018-06-22 Thread Gyan Doshi
Sorry; ignore this email. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel