Andreas Rheinhardt (12021-07-18):
> I pushed this to fix the warning, although I'd like to hear other
> peoples' opinion on whether the warning should no longer be enabled.
I personally consider it is good code hygiene to group variable
declarations.
It reduces diff noise when we need to use the
"zhilizhao(赵志立)" (12021-07-19):
> For clang, `-Wdeclaration-after-statement` has no effect with -std=c99.
Looks like a clang bug: you asked for the warning, it should give it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
> On Jul 19, 2021, at 3:23 AM, Andreas Rheinhardt
> wrote:
>
> Andreas Rheinhardt:
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> What is actually the reason that we stick to this C90 rule?
>> Is it because of compability with ancient compilers? (Given that we
>> already require several C99 f
On 2021-07-19 00:53, Andreas Rheinhardt wrote:
Andreas Rheinhardt:
Signed-off-by: Andreas Rheinhardt
---
What is actually the reason that we stick to this C90 rule?
Is it because of compability with ancient compilers? (Given that we
already require several C99 features, I doubt that there ar
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> What is actually the reason that we stick to this C90 rule?
> Is it because of compability with ancient compilers? (Given that we
> already require several C99 features, I doubt that there are compilers
> which would fail if we stoppe
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Signed-off-by: Andreas Rheinhardt
---
What is actually the reason that we stick to this C90 rule?
Is it because of compability with ancient compilers? (Given that we
already require several C99 features, I doubt that there are compilers
which would fail if we stopped adhering to the
declaration-be
