Re: [FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

2015-11-06 Thread Ganesh Ajjanagadde
On Fri, Nov 6, 2015 at 10:42 PM, Mark Harris wrote: > On Fri, Nov 6, 2015 at 12:49 PM, Ganesh Ajjanagadde > wrote: >> Somewhat ironic that this "safe" interface is actually being used >> unsafely here. This fixes the usage preventing potential null pointer >> dereference, where the old code was d

Re: [FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

2015-11-06 Thread Mark Harris
On Fri, Nov 6, 2015 at 12:49 PM, Ganesh Ajjanagadde wrote: > Somewhat ironic that this "safe" interface is actually being used > unsafely here. This fixes the usage preventing potential null pointer > dereference, where the old code was doubly broken: ctime can return > NULL, and ctime can return

[FFmpeg-devel] [PATCH] ffserver: fix incorrect strlcpy usage

2015-11-06 Thread Ganesh Ajjanagadde
Somewhat ironic that this "safe" interface is actually being used unsafely here. This fixes the usage preventing potential null pointer dereference, where the old code was doubly broken: ctime can return NULL, and ctime can return an arbitrarily long buffer. Signed-off-by: Ganesh Ajjanagadde ---