Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-20 Thread Stefano Sabatini
On date Wednesday 2023-10-18 23:44:45 +0200, Stefano Sabatini wrote: > On date Tuesday 2023-10-17 11:56:35 +0200, Stefano Sabatini wrote: > > On date Sunday 2023-10-15 19:15:16 +0200, Michael Niedermayer wrote: > > > On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote: > > > > On date

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-18 Thread Stefano Sabatini
On date Tuesday 2023-10-17 11:56:35 +0200, Stefano Sabatini wrote: > On date Sunday 2023-10-15 19:15:16 +0200, Michael Niedermayer wrote: > > On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote: > > > On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote: > > > > Fix rende

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-16 Thread Tobias Rapp
On 15/10/2023 04:59, Stefano Sabatini wrote: On date Sunday 2023-10-15 03:09:14 +0200, Timo Rothenpieler wrote: Isn't a change like that practically an ABI break, and thus would need to happen on a major bump? Yes, but in practice we are not tracking changes in the XML format, and major bumps

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-15 Thread Michael Niedermayer
On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote: > On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote: > > Fix rendering of int values within a side data element, which was > > broken since commit d2d3a83ad93, where the side data element was > > correctly marked as

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
On date Sunday 2023-10-15 03:09:14 +0200, Timo Rothenpieler wrote: > On 14.10.2023 19:24, Stefano Sabatini wrote: > > Fix rendering of int values within a side data element, which was > > broken since commit d2d3a83ad93, where the side data element was > > correctly marked as a variable fields elem

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Timo Rothenpieler
On 14.10.2023 19:24, Stefano Sabatini wrote: Fix rendering of int values within a side data element, which was broken since commit d2d3a83ad93, where the side data element was correctly marked as a variable fields element. Logic to render a string variable was implemented already, but it was not

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote: > Fix rendering of int values within a side data element, which was > broken since commit d2d3a83ad93, where the side data element was > correctly marked as a variable fields element. Logic to render a > string variable was impleme

[FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
Fix rendering of int values within a side data element, which was broken since commit d2d3a83ad93, where the side data element was correctly marked as a variable fields element. Logic to render a string variable was implemented already, but it was not implemented for the int fields path, which was