Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-07 Thread Ganesh Ajjanagadde
On Tue, Aug 4, 2015 at 8:54 PM, Ganesh Ajjanagadde wrote: > On Mon, Aug 3, 2015 at 10:47 AM, Nicolas George wrote: >> Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : >>> Trashing the state even more often just because there is one example >>> where this can already happen is not a

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-04 Thread Ganesh Ajjanagadde
On Mon, Aug 3, 2015 at 10:47 AM, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : >> Trashing the state even more often just because there is one example >> where this can already happen is not a valid reasoning. > > The changes should be applied because they

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > Trashing the state even more often just because there is one example > where this can already happen is not a valid reasoning. The changes should be applied because they are the RIGHT behaviour, as I explained in this mail: http://f

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Ganesh Ajjanagadde
On Mon, Aug 3, 2015 at 10:40 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 4:34 PM, Ganesh Ajjanagadde wrote: >> On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: >>> Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : > ffmpeg -lavfi testsrc -f framecrc | head >>>

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 4:34 PM, Ganesh Ajjanagadde wrote: > On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: >> Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : >>> > ffmpeg -lavfi testsrc -f framecrc | head >>> Thats interresting, i tried this and it did not trash my term

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Ganesh Ajjanagadde
On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: > Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : >> > ffmpeg -lavfi testsrc -f framecrc | head >> Thats interresting, i tried this and it did not trash my terminal >> also ive almost never seen ffmpeg trash my terminal with

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-01 Thread Ganesh Ajjanagadde
On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: > Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : >> > ffmpeg -lavfi testsrc -f framecrc | head >> Thats interresting, i tried this and it did not trash my terminal >> also ive almost never seen ffmpeg trash my terminal with

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-01 Thread Nicolas George
Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : > > ffmpeg -lavfi testsrc -f framecrc | head > Thats interresting, i tried this and it did not trash my terminal > also ive almost never seen ffmpeg trash my terminal with the current > code. No matter how i run it As Ganesh notic

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Ganesh Ajjanagadde
On Fri, Jul 31, 2015 at 10:15 PM, Michael Niedermayer wrote: > On Fri, Jul 31, 2015 at 10:51:31AM +0200, Nicolas George wrote: >> Le tridi 13 thermidor, an CCXXIII, Michael Niedermayer a écrit : >> > no disagreement here but as the shell does not do that (well at least >> > not bash here) >> > it

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Michael Niedermayer
On Fri, Jul 31, 2015 at 10:51:31AM +0200, Nicolas George wrote: > Le tridi 13 thermidor, an CCXXIII, Michael Niedermayer a écrit : > > no disagreement here but as the shell does not do that (well at least > > not bash here) > > it causes moderate inconvenience to the developers > > in everyday work

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Nicolas George
Le tridi 13 thermidor, an CCXXIII, Michael Niedermayer a écrit : > ATM ffmpeg in practice doesnt leave the terminal in a messed up state > from te users point of view when it crashes. Yes it does. ffmpeg does not trash the tty when it has been inhibited to do so, and one of those inhibitions is w

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Michael Niedermayer
On Thu, Jul 30, 2015 at 10:58:57PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Jul 30, 2015 at 9:53 PM, Michael Niedermayer > wrote: > > On Thu, Jul 30, 2015 at 05:57:54PM -0400, Ganesh Ajjanagadde wrote: > >> On Thu, Jul 30, 2015 at 5:49 PM, Michael Niedermayer > >> wrote: > >> > On Thu, Jul 30,

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-31 Thread Nicolas George
Le tridi 13 thermidor, an CCXXIII, Michael Niedermayer a écrit : > no disagreement here but as the shell does not do that (well at least > not bash here) > it causes moderate inconvenience to the developers > in everyday work if the terminal needs to be reset after a fate > failure And what happen

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Ganesh Ajjanagadde
On Thu, Jul 30, 2015 at 9:53 PM, Michael Niedermayer wrote: > On Thu, Jul 30, 2015 at 05:57:54PM -0400, Ganesh Ajjanagadde wrote: >> On Thu, Jul 30, 2015 at 5:49 PM, Michael Niedermayer >> wrote: >> > On Thu, Jul 30, 2015 at 02:43:01PM +0200, Michael Niedermayer wrote: >> >> On Wed, Jul 29, 2015

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Michael Niedermayer
On Thu, Jul 30, 2015 at 05:57:54PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Jul 30, 2015 at 5:49 PM, Michael Niedermayer > wrote: > > On Thu, Jul 30, 2015 at 02:43:01PM +0200, Michael Niedermayer wrote: > >> On Wed, Jul 29, 2015 at 05:28:16PM -0400, Ganesh Ajjanagadde wrote: > >> > On Wed, Jul 2

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Ganesh Ajjanagadde
On Thu, Jul 30, 2015 at 5:49 PM, Michael Niedermayer wrote: > On Thu, Jul 30, 2015 at 02:43:01PM +0200, Michael Niedermayer wrote: >> On Wed, Jul 29, 2015 at 05:28:16PM -0400, Ganesh Ajjanagadde wrote: >> > On Wed, Jul 29, 2015 at 3:27 PM, Michael Niedermayer >> > wrote: >> > > On Wed, Jul 29, 20

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Michael Niedermayer
On Thu, Jul 30, 2015 at 02:43:01PM +0200, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 05:28:16PM -0400, Ganesh Ajjanagadde wrote: > > On Wed, Jul 29, 2015 at 3:27 PM, Michael Niedermayer > > wrote: > > > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > > >> On Mon, Ju

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-30 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 05:28:16PM -0400, Ganesh Ajjanagadde wrote: > On Wed, Jul 29, 2015 at 3:27 PM, Michael Niedermayer > wrote: > > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > >> On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde > >> wrote: > >> > This fixes Ticket

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Ganesh Ajjanagadde
On Wed, Jul 29, 2015 at 3:27 PM, Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: >> On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde >> wrote: >> > This fixes Ticket2964 >> > >> > Signed-off-by: Ganesh Ajjanagadde >> > --- >> > ffmpeg.c | 2 +-

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread wm4
On Wed, 29 Jul 2015 21:27:09 +0200 Michael Niedermayer wrote: > On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > > On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde > > wrote: > > > This fixes Ticket2964 > > > > > > Signed-off-by: Ganesh Ajjanagadde > > > --- > > > ffmpe

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Michael Niedermayer
On Wed, Jul 29, 2015 at 02:43:52PM -0400, Ganesh Ajjanagadde wrote: > On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde > wrote: > > This fixes Ticket2964 > > > > Signed-off-by: Ganesh Ajjanagadde > > --- > > ffmpeg.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-29 Thread Ganesh Ajjanagadde
On Mon, Jul 27, 2015 at 9:56 AM, Ganesh Ajjanagadde wrote: > This fixes Ticket2964 > > Signed-off-by: Ganesh Ajjanagadde > --- > ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 751c7d3..98f812e 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c

[FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-07-27 Thread Ganesh Ajjanagadde
This fixes Ticket2964 Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 751c7d3..98f812e 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -372,7 +372,7 @@ void term_init(void) struct termios tty;