Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-04 Thread Hendrik Leppkes
On Tue, Aug 4, 2015 at 1:35 PM, Michael Niedermayer wrote: > On Mon, Aug 03, 2015 at 10:02:17PM +0200, Hendrik Leppkes wrote: >> Mixing stdio and low-level IO on stdin is not safe. >> --- >> ffmpeg.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) > > LGTM too > Applied. _

Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-04 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:02:17PM +0200, Hendrik Leppkes wrote: > Mixing stdio and low-level IO on stdin is not safe. > --- > ffmpeg.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) LGTM too [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 10:12 PM, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : >> Mixing stdio and low-level IO on stdin is not safe. >> --- >> ffmpeg.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/ffmpeg.c b/ff

Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > Mixing stdio and low-level IO on stdin is not safe. > --- > ffmpeg.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 5575e2f..206b3dc 100644 > --- a/ffmpeg.c > +++ b

[FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Hendrik Leppkes
Mixing stdio and low-level IO on stdin is not safe. --- ffmpeg.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 5575e2f..206b3dc 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3428,9 +3428,17 @@ static int check_keyboard_interaction(int64_t cu