Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Nicolas George
Mark Thompson (2018-01-25): > Please don't. In this case the semantics of ignoring the signal are > clear and I think we can be confident the change is ok, but that > certainly isn't true in almost all other cases (especially if people > are going to catch signals and do something in the signal ha

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Mark Thompson
On 25/01/18 23:22, Nicolas George wrote: > Mark Thompson (2018-01-25): >> And applied. > > I am glad to see that my advice was so well taken into account. From now > on, I will defer to you on matters relating to Unix system programming, > especially signals, shall I? Please don't. In this case

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Nicolas George
Mark Thompson (2018-01-25): > And applied. I am glad to see that my advice was so well taken into account. From now on, I will defer to you on matters relating to Unix system programming, especially signals, shall I? Regards, -- Nicolas George signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-25 Thread Mark Thompson
On 19/01/18 00:18, Mark Thompson wrote: > On 19/01/18 00:08, Carl Eugen Hoyos wrote: >> 2018-01-19 0:42 GMT+01:00 Mark Thompson : >> >>> To offer this suggestion in a more concrete form. >> >> Works as expected here except for printing an error which >> may be intended. > > Yes, that's intended.

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-20 Thread Mark Thompson
On 18/01/18 23:42, Mark Thompson wrote: > On systems which deliver SIGPIPE (Unices), a broken pipe will currently > result in the immediate termination of the ffmpeg process (the default > disposition as required by POSIX). This is undesirable, because while > the broken pipe is likely fatal to us

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-19 Thread Nicolas George
Mark Thompson (2018-01-18): > On systems which deliver SIGPIPE (Unices), a broken pipe will currently > result in the immediate termination of the ffmpeg process (the default > disposition as required by POSIX). This is undesirable, because while > the broken pipe is likely fatal to useful cleanup

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-18 Thread Mark Thompson
On 19/01/18 00:08, Carl Eugen Hoyos wrote: > 2018-01-19 0:42 GMT+01:00 Mark Thompson : > >> To offer this suggestion in a more concrete form. > > Works as expected here except for printing an error which > may be intended. Yes, that's intended. Data may have been lost unexpectedly (as with any

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-18 Thread Carl Eugen Hoyos
2018-01-19 0:42 GMT+01:00 Mark Thompson : > To offer this suggestion in a more concrete form. Works as expected here except for printing an error which may be intended. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

[FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-18 Thread Mark Thompson
On systems which deliver SIGPIPE (Unices), a broken pipe will currently result in the immediate termination of the ffmpeg process (the default disposition as required by POSIX). This is undesirable, because while the broken pipe is likely fatal to useful cleanup of whatever component is writing to