Re: [FFmpeg-devel] [PATCH] fate: test flac LPC encoder

2014-08-14 Thread James Darnley
After further searching and understanding the makefile I see that the lpc code is tested by the complete fate sample suite. This patch is unnecessary. Anyway to answer the questions... On 2014-08-14 18:14, Christophe Gisquet wrote: > Hi, > > 2014-08-14 18:08 GMT+02:00 James Darnley : >> Minimum

Re: [FFmpeg-devel] [PATCH] fate: test flac LPC encoder

2014-08-14 Thread Christophe Gisquet
Hi, 2014-08-14 18:08 GMT+02:00 James Darnley : > Minimum 1, maximum 8. Should I find out what order(s) are actually chosen? The encoder algorithm might change and make that information useless, but that could be useful. I fear that only checking which orders it *tests* is insufficient: if the ds

Re: [FFmpeg-devel] [PATCH] fate: test flac LPC encoder

2014-08-14 Thread James Darnley
On 2014-08-14 18:03, Christophe Gisquet wrote: > Hi, > > 2014-08-14 17:15 GMT+02:00 James Darnley : >> The LPC encoder is not used at compression levels below 3 but the basic >> acodec >> test uses -compression_level 2. This adds a test using -compression_level 5, >> which is the current default

Re: [FFmpeg-devel] [PATCH] fate: test flac LPC encoder

2014-08-14 Thread Christophe Gisquet
Hi, 2014-08-14 17:15 GMT+02:00 James Darnley : > The LPC encoder is not used at compression levels below 3 but the basic acodec > test uses -compression_level 2. This adds a test using -compression_level 5, > which is the current default. What order is used in that case? It may be good to in fac

[FFmpeg-devel] [PATCH] fate: test flac LPC encoder

2014-08-14 Thread James Darnley
The LPC encoder is not used at compression levels below 3 but the basic acodec test uses -compression_level 2. This adds a test using -compression_level 5, which is the current default. --- tests/fate/acodec.mak|4 +++- tests/ref/acodec/flac-comp-5 |4 2 files changed, 7 inse