Re: [FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

2017-06-12 Thread Paul B Mahol
On 6/12/17, Michael Bradshaw wrote: > On Mon, Jun 12, 2017 at 11:14 AM, James Almer wrote: >> On 6/12/2017 3:07 PM, Paul B Mahol wrote: >>> OK, please apply. >> >> Wouldn't it be better/proper to add the license header to the file >> instead? > > Yeah. Paul, as the proper copyright holder of the

Re: [FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

2017-06-12 Thread Michael Bradshaw
On Mon, Jun 12, 2017 at 11:14 AM, James Almer wrote: > On 6/12/2017 3:07 PM, Paul B Mahol wrote: >> OK, please apply. > > Wouldn't it be better/proper to add the license header to the file instead? Yeah. Paul, as the proper copyright holder of the sofa2wavs.c file, could you add the license heade

Re: [FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

2017-06-12 Thread James Almer
On 6/12/2017 3:07 PM, Paul B Mahol wrote: > On 6/12/17, Michael Bradshaw wrote: >> commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs >> tool, which breaks fate: >> $ make fate V=1 >> TESTsource >> ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg" >> 'runloc

Re: [FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

2017-06-12 Thread Paul B Mahol
On 6/12/17, Michael Bradshaw wrote: > commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs > tool, which breaks fate: > $ make fate V=1 > TESTsource > ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg" > 'runlocal fate/source-check.sh' '' '' '' '1' '' '' '' ''

[FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

2017-06-12 Thread Michael Bradshaw
commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs tool, which breaks fate: $ make fate V=1 TESTsource ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg" 'runlocal fate/source-check.sh' '' '' '' '1' '' '' '' '' '' '' '' '' '' ./tests/fate/source-check.sh ./tes