Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-21 Thread Clément Bœsch
On Thu, Jul 20, 2017 at 05:42:51PM +0200, Nicolas George wrote: [...] > diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c > index c4a5ae3742..f94c3ed9dd 100644 > --- a/libavfilter/vsrc_testsrc.c > +++ b/libavfilter/vsrc_testsrc.c > @@ -66,6 +66,9 @@ typedef struct TestSourceConte

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 05:38:18PM +0200, Peter Große wrote: > On Thu, 20 Jul 2017 17:19:36 +0200 > Tobias Rapp wrote: > > > > When I re-add --disable-optimizations --enable-mmx --disable-stripping to > > > my > > > configure command line, the test succeeds. > > > > > > Any further comments to t

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Nicolas George a écrit : >the attached patch. Sorry. Regards, -- Nicolas George From e50bd258ac22d5758348eafa7203f264dd98f580 Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Thu, 20 Jul 2017 17:35:44 +0200 Subject: [PATCH] lavfi/testsrc2: f

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Nicolas George a écrit : > testsrc2 does not handle alpha, though, so most of the video is > transparent. I will have a look to see if it can be improved. Have a look at the attached patch. (Not complete, but working.) testsrc2=s=1024x768:alpha=255[a];testsrc2=alp

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Thu, 20 Jul 2017 17:19:36 +0200 Tobias Rapp wrote: > > When I re-add --disable-optimizations --enable-mmx --disable-stripping to my > > configure command line, the test succeeds. > > > > Any further comments to the patch and test case? > > Maybe try adding -sws_flags +accurate_rnd+bitexact

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Tobias Rapp
On 20.07.2017 17:06, Peter Große wrote: On Wed, 19 Jul 2017 21:00:49 +0200 Peter Große wrote: I was able to reproduce your checksums only after removing --disable-optimizations --disable-mmx --disable-stripping from my configure command. I thought optimizations should have no impact on the

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Peter Große a écrit : > After some further tests, it seems swscale (used as the auto_scaler in the > test) produces slightly different output depending on whether MMX is enabled > or > not. > > When I re-add --disable-optimizations --enable-mmx --disable-stripping

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Wed, 19 Jul 2017 21:00:49 +0200 Peter Große wrote: > I was able to reproduce your checksums only after removing > > --disable-optimizations --disable-mmx --disable-stripping > > from my configure command. I thought optimizations should have no > impact on the result?! After some further t

[FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-19 Thread Peter Große
Signed-off-by: Peter Große --- Updated version of the test. I was able to reproduce your checksums only after removing --disable-optimizations --disable-mmx --disable-stripping from my configure command. I thought optimizations should have no impact on the result?! tests/fate/filter-video.m

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-19 Thread Michael Niedermayer
On Tue, Jul 18, 2017 at 05:03:52PM +0200, Peter Große wrote: > Signed-off-by: Peter Große > --- > tests/fate/filter-video.mak | 5 + > tests/ref/fate/filter-overlay-main-alpha | 15 +++ > 2 files changed, 20 insertions(+) > create mode 100644 tests/ref/fate/filter-o

[FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-18 Thread Peter Große
Signed-off-by: Peter Große --- tests/fate/filter-video.mak | 5 + tests/ref/fate/filter-overlay-main-alpha | 15 +++ 2 files changed, 20 insertions(+) create mode 100644 tests/ref/fate/filter-overlay-main-alpha diff --git a/tests/fate/filter-video.mak b/tests/fate/