Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-07-01 Thread David Andreoletti
**Help needed**: I am still hopeful the patch will get some attention but hope is fading now (due to summer) :-). It's an easy patch and probably takes 10-20min to review. Quick patch's status:- it compiles on the latest ffmpeg 4.3,- it passes the tests,- the associated documentation has been updat

Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-24 Thread David Andreoletti
FFmpeg team, Is there any other discussion/changes needed to get this contribution merged in ? Regards, On Tue, May 19, 2020 12:36 PM, David Andreoletti da...@andreoletti.net wrote: Manolis: drawtext's text expansion section [0] does not mention the special variable %{frame_num} has 0 padda

Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-19 Thread David Andreoletti
Manolis: drawtext's text expansion section [0] does not mention the special variable %{frame_num} has 0 paddable. When I tested locally (on master), it is not 0 padded. Running through different scenario, I recommend the expanded file path to not contain 0 padded frame number:- if automatic paddin

Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-19 Thread Manolis Stamatogiannakis
Hi David, Not a full review, but a minor point that popped in mind. It is common to pad serially numbered files with 0. E.g. if you have <1000 files, the 9th file will be named file009.txt. Is this case handled by the expansion? Or is it assumed that the text file numbers are not zero-padded? If

Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-18 Thread David Andreoletti
Hi ffmpeg maintainers / community, New contributor here. The patch [0] for the drawtext filter was submitted some time ago now but has been reviewed yet. It seems there is no official maintainer for this filter (as per the MAINTAINERS file) What should be done to have it reviewed ? [0] https://pat

[FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-11 Thread David Andreoletti
drawtext allows a file to be reloaded per frame. However, the file to be reloaded is constant across frame. With textfile now supporting text expansion, a different file can be reloaded per frame. Eg: textfile=/path/fo/file{frame_num}.txt Signed-off-by: David Andreoletti --- doc/filters.texi