martin schitter (HE12025-02-28):
> This kind of checks should better happen in some kind of CI based pipeline
> supporting direct feedback to the contributors before accepting the patches
> for any further human review by maintainers or on public mailing lists.
>
> That's why I really like GitLab
On Fri, Feb 28, 2025 at 4:09 PM Nicolas George wrote:
> Hard rules on cosmetic matters are a terrible idea, whether they are
> enforced at the level of the language or downstream from it.
agree to disagree :)
--
Vittorio
___
ffmpeg-devel mailing list
Hi Lynne
On Fri, Feb 28, 2025 at 01:24:46PM +0100, Lynne wrote:
>
>
> On 28/02/2025 03:33, Michael Niedermayer wrote:
> > On Fri, Feb 28, 2025 at 03:25:06AM +0100, Lynne wrote:
> > > On 27/02/2025 02:10, Michael Niedermayer wrote:
> > > > Signed-off-by: Michael Niedermayer
> > > > ---
> > > >
On 2/28/25 15:07, Devin Heitmueller wrote:
I've been working on the codebase for more than eight years, and
didn't know it existed. I would suggest that people reviewing patches
and rejecting them due to style issues that they recommend to
submitters to run the tool. In my experience, develo
Devin Heitmueller (HE12025-02-28):
> I've been working on the codebase for more than eight years, and
> didn't know it existed.
# @anchor{Submitting patches}
# …
# Use the patcheck tool of FFmpeg to check your patch.
Fourth point in doc/developer.texi.
Regards,
--
Nicolas George
On Thu, Feb 27, 2025 at 7:59 PM Michael Niedermayer
wrote:
> we have tools/patcheck :)
> I have the feeling we started forgeting about it
I've been working on the codebase for more than eight years, and
didn't know it existed. I would suggest that people reviewing patches
and rejecting them due
On Fri, Feb 28, 2025 at 1:25 PM Lynne wrote:
>
>
> On 28/02/2025 03:33, Michael Niedermayer wrote:
> > On Fri, Feb 28, 2025 at 03:25:06AM +0100, Lynne wrote:
> >> On 27/02/2025 02:10, Michael Niedermayer wrote:
> >>> Signed-off-by: Michael Niedermayer
> >>> ---
> >>>doc/developer.texi | 11 +
On 28/02/2025 03:33, Michael Niedermayer wrote:
On Fri, Feb 28, 2025 at 03:25:06AM +0100, Lynne wrote:
On 27/02/2025 02:10, Michael Niedermayer wrote:
Signed-off-by: Michael Niedermayer
---
doc/developer.texi | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
On 28 Feb 2025, at 8:53, Nicolas George wrote:
> Michael Niedermayer (HE12025-02-28):
>> we have tools/patcheck :)
>> I have the feeling we started forgeting about it
>
> You cannot click on it. Therefore, the coders who are somehow capable of
> producing C code at quality level for FFmpeg but
Michael Niedermayer (HE12025-02-28):
> we have tools/patcheck :)
> I have the feeling we started forgeting about it
You cannot click on it. Therefore, the coders who are somehow capable of
producing C code at quality level for FFmpeg but unable to use a command
line and unable to learn will not be
On Fri, Feb 28, 2025 at 12:25:43AM +0100, epira...@gmail.com wrote:
>
>
> On 28 Feb 2025, at 0:14, Michael Niedermayer wrote:
>
> > Hi
> >
> > On Thu, Feb 27, 2025 at 11:46:54PM +0100, epira...@gmail.com wrote:
> >> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
> >>
> >>> Signed-off-by: Mi
On Fri, Feb 28, 2025 at 03:25:06AM +0100, Lynne wrote:
> On 27/02/2025 02:10, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/developer.texi | 11 +--
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/developer.texi b/doc/dev
On 27/02/2025 02:10, Michael Niedermayer wrote:
Signed-off-by: Michael Niedermayer
---
doc/developer.texi | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index a1bfe180c9b..6a753f99da6 100644
--- a/doc/developer.texi
+++
> -Original Message-
> From: ffmpeg-devel On Behalf Of Devin
> Heitmueller
> Sent: Freitag, 28. Februar 2025 01:40
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule
>
> On Thu, Feb 27, 202
On Thu, Feb 27, 2025 at 07:40:14PM -0500, Devin Heitmueller wrote:
> On Thu, Feb 27, 2025 at 5:57 PM James Almer wrote:
> > > would lve a format defining script with a prehook that formats your
> > > patches before sending <3
> >
> > That can be done automatically as one of the many jobs CI ru
On Thu, Feb 27, 2025 at 5:57 PM James Almer wrote:
> > would lve a format defining script with a prehook that formats your
> > patches before sending <3
>
> That can be done automatically as one of the many jobs CI runs once we
> move to forgejo/gitlab. Same with every other check in patcheck.
On 28 Feb 2025, at 0:14, Michael Niedermayer wrote:
> Hi
>
> On Thu, Feb 27, 2025 at 11:46:54PM +0100, epira...@gmail.com wrote:
>> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
>>
>>> Signed-off-by: Michael Niedermayer
>>> ---
>>> doc/developer.texi | 11 +--
>>> 1 file changed
Hi
On Thu, Feb 27, 2025 at 11:46:54PM +0100, epira...@gmail.com wrote:
> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
>
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/developer.texi | 11 +--
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/dev
On 2/27/2025 7:53 PM, Vittorio Giovara wrote:
On Thu, Feb 27, 2025 at 11:47 PM wrote:
On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
Signed-off-by: Michael Niedermayer
---
doc/developer.texi | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/develope
On Thu, Feb 27, 2025 at 11:47 PM wrote:
> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
>
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/developer.texi | 11 +--
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/developer.texi b/doc/developer.tex
On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> doc/developer.texi | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/doc/developer.texi b/doc/developer.texi
> index a1bfe180c9b..6a753f99da6 100644
> --- a/doc/dev
Signed-off-by: Michael Niedermayer
---
doc/developer.texi | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index a1bfe180c9b..6a753f99da6 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -179,18 +179,17 @@ int field
22 matches
Mail list logo
