Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-16 Thread wm4
On Fri, 15 Jan 2016 10:39:59 -0800 Richard Smith wrote: > On Fri Jan 15 08:51:07 CET 2016 wm4 wrote; > > On Thu, 14 Jan 2016 13:58:14 -0800 Richard Smith > > wrote: > > > libavutil/pixfmt.h defines a collection of endian-specific pixel formats > > > as > > > macros. These macro names can ca

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Richard Smith
On Fri Jan 15 08:51:07 CET 2016 wm4 wrote; > On Thu, 14 Jan 2016 13:58:14 -0800 Richard Smith > wrote: > > libavutil/pixfmt.h defines a collection of endian-specific pixel formats as > > macros. These macro names can cause conflicts with external projects that > > use those identifiers for their

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Jean-Yves Avenard
On 15 January 2016 at 18:51, wm4 wrote: > API users might check for the existence of such pixfmts with #ifdef, > and I don't understand the reasoning behind your patch. Why would > external projects redefine these macros? All other pixfmts are already enums, why the discrepency ? Having everythin

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-15 Thread Hendrik Leppkes
On Thu, Jan 14, 2016 at 10:58 PM, Richard Smith wrote: > libavutil/pixfmt.h defines a collection of endian-specific pixel formats as > macros. These macro names can cause conflicts with external projects that > use those identifiers for their own purposes. Here's a patch to define > these aliases

Re: [FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-14 Thread wm4
On Thu, 14 Jan 2016 13:58:14 -0800 Richard Smith wrote: > libavutil/pixfmt.h defines a collection of endian-specific pixel formats as > macros. These macro names can cause conflicts with external projects that > use those identifiers for their own purposes. Here's a patch to define > these aliase

[FFmpeg-devel] [PATCH] define AVPixelFormat aliases as enumerators instead of macros

2016-01-14 Thread Richard Smith
libavutil/pixfmt.h defines a collection of endian-specific pixel formats as macros. These macro names can cause conflicts with external projects that use those identifiers for their own purposes. Here's a patch to define these aliases as enumerators instead of macros, please consider merging: htt