Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-24 Thread Ganesh Ajjanagadde
On Mon, Aug 24, 2015 at 8:28 AM, Ganesh Ajjanagadde wrote: > On Mon, Aug 24, 2015 at 8:20 AM, Nicolas George wrote: >> Le septidi 7 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >>> >> +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then >> >>> The (-q) is for suppressin

Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-24 Thread Ganesh Ajjanagadde
On Mon, Aug 24, 2015 at 8:20 AM, Nicolas George wrote: > Le septidi 7 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> >> +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then > >> The (-q) is for suppressing output, only yielding the exit code. >> The reason it works is b

Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-24 Thread Nicolas George
Le septidi 7 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > >> +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then > The (-q) is for suppressing output, only yielding the exit code. > The reason it works is because '^' matches the beginning of a line, > not the beginnin

Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-24 Thread Ganesh Ajjanagadde
On Mon, Aug 24, 2015 at 2:49 AM, Carl Eugen Hoyos wrote: > Ganesh Ajjanagadde gmail.com> writes: > >> +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then > > Will this not trigger for 4.4.2? No. Here is a test: echo "4.4.2" | grep '^4\.2' vs echo "4.2" | grep '^4\.2'. The (-

Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-23 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde gmail.com> writes: > +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then Will this not trigger for 4.4.2? > +warn "$gcc_version does not build ffmpeg correctly. > Please do not use GCC 4.2!" > +warn "See Ticket #1464 for more details." P

[FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-23 Thread Ganesh Ajjanagadde
The wiki, Ticket1464, and Ticket3970 warn about the usage of GCC 4.2. This fixes Ticket3970. Signed-off-by: Ganesh Ajjanagadde --- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e67ddf6..5b10017 100755 --- a/configure +++ b/configu